This repository was archived by the owner on Feb 24, 2020. It is now read-only.
common: introduce RemoveEmptyLines() #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
ok to test |
rkt/api_service.go
Outdated
| } | ||
|
|
||
| func (sw LogsStreamWriter) Write(b []byte) (int, error) { | ||
| // Remove empty lines |
Couple of places uses the same functionality which removes empty lines from a multiline string. This patch introduces RemoveEmptyLines() function to achive this functionality in one place and get rid from code duplication.
Contributor
Author
|
force pushed |
Member
|
Thanks, LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of places uses the same functionality which removes empty lines from
a multiline string. This patch introduces RemoveEmptyLines() function to
achive this functionality in one place and get rid from code duplication.
Not sure that
common/common.gois the best place for this although.