This repository was archived by the owner on Feb 24, 2020. It is now read-only.
pkg/tar/chroot: avoid errwrap in function called by multicall #2997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can see the error message now, this time on |
pkg/tar/chroot.go
Outdated
| } | ||
| if err := syscall.Chdir("/"); err != nil { | ||
| return errwrap.Wrap(errors.New("failed to chdir"), err) | ||
| return fmt.Errorf("failed to chdir: %v", err) |
Member
|
A nit. LGTM after that. |
When a function is called by multicall, it is not possible to use errwrap because the log pkg is not initialized yet. Also initialize the log pkg will not show the correct indentation in the log because the new process will start printing from the most left. Fixes rkt#2984
Member
I wonder which file it is... |
391c730 to
dbc4e86
Compare
Contributor
Author
|
Patch updated. Also I enhanced the error message in case of |
pkg/tar/tar.go
Outdated
| err = extractFile(tr, target, hdr, overwrite, editor) | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("%s. extractFile failed on target: %s",err, target) |
Member
There was a problem hiding this comment.
target is the output directory, shouldn't we print $target/hdr.Name?
dbc4e86 to
1e7b1c3
Compare
pkg/tar/tar.go
Outdated
| err = extractFile(tr, target, hdr, overwrite, editor) | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("extractFile failed on %s/%s: %v", target, hdr.Name, err) |
Member
There was a problem hiding this comment.
fmt.Errorf("could not extract file %q in %q: %v", hdr.Name, target, err)
Sometimes tests fail on `ExtractTarInsecure()` and the error message was not clear enough to reproduce the fail. In case of error from `extractFile()` or `UtimesNano()`, `ExtractTarInsecure()` adds the file name to the returned error.
1e7b1c3 to
3c21c4a
Compare
Member
|
lgtm |
Member
|
The failure on Semaphore does not seem related to this PR: "fetch: bad HTTP status code: 504" (TestFetch) |
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function is called by multicall, it is not possible to use errwrap
because the log pkg is not initialized yet. Also initialize the log pkg will
not show the correct indentation in the log because the new process will
start printing from the most left.
Fixes #2984