this is awkward.... but is this change in the right direction, or does --caps-retain make more sense?

I personally prefer caps-* because it takes a list of options.

I s'pose the other option is to convert everything to --caps and retain a hiddne --cap for backwards compatibility? I'd be happy to make that change if you and the original author (cc @alban) think that's better as well.

+1

On 27 July 2016 at 10:55, Euan Kemp [email protected] wrote:

I personally prefer caps-* because it takes a list of options.

I s'pose the other option is to convert everything to --caps and retain a
hiddne --cap for backwards compatibility?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2994 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN8XYQQsBzlnIUp06r-43-55lpPnMks5qZ5uggaJpZM4JWaF6
.

sgtm

I am fine either way. If we add --caps and hide --cap, the bash completion should only show one of them, right?

Don't think that matters too much

On 28 July 2016 at 04:14, Alban Crequy [email protected] wrote:

I am fine either way. If we add --caps and hide --cap, the bash
completion should only show one of them, right?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2994 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN209MrgPypMRiEMDPidPN_HNib-aks5qaI8TgaJpZM4JWaF6
.

There was a discussion on naming the --cap-remove and --cap-retain flags: #2771 (comment)

@lucab do you agree on the suggestion to rename to --caps-remove and --caps-retain?

The renaming suggestion sounds good to me.

Experimentally, bash completion shows both --cap-* and --caps-* when using hidden flags. Similarly it shows the other hidden flags (e.g. --cpuprofile). Since it makes sense for hidden flags to, by default, not tab-complete either, I'll file an issue against upstream for that. I don't think we should let it block this since it doesn't seem like a big deal though.

Moving back to ready for review.

Changes LGTM, however this PR now has some conflicts which need a rebase.

rebased, and next time we update cobra the deprecated flags will be hidden too (spf13/cobra#313)

LGTM