This repository was archived by the owner on Feb 24, 2020. It is now read-only.
rkt-monitor additional fix #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
336bb94 to
9739d83
Compare
tests/rkt-monitor/build-stresser.sh
Outdated
| acbuild --debug set-exec -- /worker | ||
|
|
||
| acbuild --debug write --overwrite "${1}"-stresser.aci | ||
|
|
Contributor
|
Small nit, LGTM. |
Member
|
Shouldn't scripts/bump-release update the version automatically at each release? I wonder why it was not picked up. |
9739d83 to
960047a
Compare
960047a to
52fce1c
Compare
Contributor
Author
Contributor
|
LGTM |
Contributor
|
I like previous idea to get version in time of building instead of patching each file after version bump. |
Contributor
|
@jellonek it would certainly be nicer if we had this coded in one place - want to file a follow up? this lgtm for now |
Contributor
|
Done. #2995 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line parsing the actual version of rkt, so if the version will be change then this line give us right number of it. Before this rkt has in files encrypted line with version number.