This repository was archived by the owner on Feb 24, 2020. It is now read-only.
functional tests: set cpu isolator correctly #2979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACE spec defines limit as: *limit*: cores that can be consumed before the kernel temporarily throttles the process and core as: *core*: seconds/second that the app/pod will be able to run. e.g. 1 (or 1000m for 1000 milli-seconds) would represent full use of a single CPU core every second. So setting 100 would mean 100 seconds/second which doesn't make sense. Somehow this wasn't failing until now but testing the flavor src with the (yet to be released) systemd v231 makes it fail.
Member
|
The 2 following changes makes systemd refuse percentages that are over 100%: |
Member
|
Is the error user-friendly if the ACI manifest wrongly contains Otherwise, LGTM. |
Member
Author
|
No, there's no error, we accept 250. |
Member
Author
|
Test failures are not related, I'm gonna merge this. If we want to protect from users writing things like "250" we can do a follow-up to update the isolator validator in the spec. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACE spec defines limit as:
limit: cores that can be consumed before the kernel temporarily throttles
the process
and core as:
core: seconds/second that the app/pod will be able to run. e.g. 1 (or
1000m for 1000 milli-seconds) would represent full use of a single CPU
core every second.
So setting 100 would mean 100 seconds/second which doesn't make sense.
Somehow this wasn't failing until now but testing the flavor src with
the (yet to be released) systemd v231 makes it fail.