This repository was archived by the owner on Feb 24, 2020. It is now read-only.
api_service: Add lru cache to cache image info #2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Blocking on #2891 |
Member
|
#2891 is merged. I'm not sure what's remaining here. |
Contributor
Author
|
This has commits to add cache for the image info. I will rebase it. |
9e936bb to
9e1c212
Compare
Contributor
Author
|
Updated the PR, ptal, thank you :) |
68fe74b to
defa7da
Compare
rkt/api_service.go
Outdated
| const ( | ||
| // Default size for the pod LRU cache. | ||
| defaultPodCacheSize = 512 | ||
| // Default size for the image LUR cache. |
Contributor
|
lgtm after small nit |
Member
|
No further concerns from my side. |
Contributor
Author
|
Updated. |
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2877
Depends on #2909 and #2891
The last 3 commits are new. Basically it adds an in-memory cache to cache image object, and reads the disk when there is a cache miss.
If the image is removed (by stating the image manifest path), return nil.