This repository was archived by the owner on Feb 24, 2020. It is now read-only.
functional tests: fix ACE validator race #1802
Merged
+38
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "main" and "sidekick" stages of ACE validator run in parallel. Most of the time the "main" stage is first with printing its OK message, but sometimes the "sidekick" wins the race. In the latter case the test failed. Now the test expects "prestart" to be first, followed up by "main" and "sidekick" in any order and then "poststop" to be last.
|
LGTM |
iaguis
added a commit
that referenced
this pull request
Nov 27, 2015
functional tests: fix ACE validator race
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failed, because it expected ACE validator to print several OK messages in strict order (prestart, main, sidekick and poststop). But main and sidekick run in parallel, so the order of OK messages was sometimes prestart, sidekick, main and poststop.
Fixes #1781.