Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: corda/corda-runtime-os
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: release/os/5.3
Choose a base ref
...
head repository: corda/corda-runtime-os
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/ledger-library
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 376 files changed
  • 9 contributors

Commits on Oct 23, 2024

  1. R3SOL-372 Extract Uniqueness code to a library (#6364)

    Main changes in this PR:
    - `BackingStore` and `UniquenessChecker` interfaces are now part of the `ledger-lib-uniqueness` library
    - The `BackingStore` logic is basically common for C5 and DLT except for how we establish the DB connection.
       That's the reason we have a base abstract class now called `JPABackingStoreBase`.
       Both C5 and DLT will inherit from this. In C5 it's called `JPABackingStoreOsgiImpl` and the entity manager
       is acquired through `DbConnectionManager`.
    - Thankfully the core uniqueness checker logic is the same for C5/DLT so only C5 will extend
      `BatchedUniquenessCheckerImpl` with the necessary OSGi things.
    - `BatchedUniquenessCheckerImplTest` tests the main UniquenessChecker logic
    - `JPABackingStoreOsgiImplIntegrationTests`, `JPABackingStoreEntitiesIntegrationTest` tests BackingStore in C5.
        We will have testcontainers integration tests in DLT.
    - `JPABackingStoreOsgiImplBenchmark` still exists and still works.
    - `UniquenessCheckerImplDBIntegrationTests` is the integration test for C5, will have testcontainers version in DLT.
    nkovacsx authored and lankydan committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2298213 View commit details
    Browse the repository at this point in the history
  2. R3SOL-372 Extract Uniqueness code to a library (#6370)

    Main changes in this PR:
    - `BackingStore` and `UniquenessChecker` interfaces are now part of the `ledger-lib-uniqueness` library
    - The `BackingStore` logic is basically common for C5 and DLT except for how we establish the DB connection.
       That's the reason we have a base abstract class now called `JPABackingStoreBase`.
       Both C5 and DLT will inherit from this. In C5 it's called `JPABackingStoreOsgiImpl` and the entity manager
       is acquired through `DbConnectionManager`.
    - Thankfully the core uniqueness checker logic is the same for C5/DLT so only C5 will extend
      `BatchedUniquenessCheckerImpl` with the necessary OSGi things.
    - `BatchedUniquenessCheckerImplTest` tests the main UniquenessChecker logic
    - `JPABackingStoreOsgiImplIntegrationTests`, `JPABackingStoreEntitiesIntegrationTest` tests BackingStore in C5.
        We will have testcontainers integration tests in DLT.
    - `JPABackingStoreOsgiImplBenchmark` still exists and still works.
    - `UniquenessCheckerImplDBIntegrationTests` is the integration test for C5, will have testcontainers version in DLT.
    
    Co-authored-by: nkovacsx <[email protected]>
    lankydan and nkovacsx authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c570ab5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. R3SOL-368 Move ledger flow code from components into a new library (#…

    …6353)
    
    Put ledger flow code into a new library. Uncoupled the new libraries dependencies and transitive dependencies from the avro schema. Pulling out code where needed into new modules (if there isn't a sensible place).
    
    Co-authored-by: Dan Newton <[email protected]>
    williamvigorr3 and lankydan authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c80cfb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge remote-tracking branch 'origin/release/os/5.3' into driessamyn/…

    …merge-release-branch
    Dries Samyn committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f463ae1 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge pull request #6377 from corda/driessamyn/merge-release-branch

    R3SOL-0 - merge release branch
    lankydan authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1282df9 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    69bc093 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. R3SOL-535 Extract verification logic to the ledger library (#6376)

    Extract Block structural verification logic to the ledger library
    nkovacsx authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    98bddae View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. R3SOL-534 Extract filtered transaction (#6403)

    Extract filtered transactions into the ledger library.
    
    ---------
    
    Co-authored-by: Jenny Yang <[email protected]>
    williamvigorr3 and jennyang-r3 authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ed8b0e1 View commit details
    Browse the repository at this point in the history
  2. R3SOL-1446 signing verifying extraction (#6398)

    restructured C5 to share verification and signing services with corda-dlt
    ---------
    Co-authored-by: PranuR3 <[email protected]>
    Co-authored-by: Dan Newton <[email protected]>
    3 people authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5703c44 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. R3SOL-1765 privacy salt provider (#6410)

    - added privacySalt member variable to UtxoTransactionBuilderInternal so that it can be set from dlt and use it for transaction in dlt.
    - made conditionally use available privacySalt depending on platform (dlt or c5)
    
    ---------
    
    Co-authored-by: Will Vigor <[email protected]>
    jennyang-r3 and williamvigorr3 authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    98d3920 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2025

  1. Configuration menu
    Copy the full SHA
    4b01d40 View commit details
    Browse the repository at this point in the history
Loading