Skip to content

Commit 7500335

Browse files
lankydanKatelyn Baker
lankydan
authored and
Katelyn Baker
committed
CORDA-2535 - Fixes to IRS demo (#4995)
* CORDA-2535 Move classes from test src to main For some reason a load of classes were in the test src rather than the main src even though they were needed during runtime. These have been moved back into main so they are compiled for use in the demo app. * CORDA-2535 Fix missing trade id irs-demo home page Change `deal.ref` to `deal.common.tradeID` * CORDA-2535 Highlight in irs-demo that `node` module should not be depended on The demo relies on `node` unless some larger refactoring is made. This is being kept as it is, but to discourage developers from doing the same in their CorDapps, a comment has been added to `build.gradle` explaining why it is there and that developers should not do the same.
1 parent fe41d9b commit 7500335

File tree

5 files changed

+7
-3
lines changed

5 files changed

+7
-3
lines changed

‎samples/irs-demo/cordapp/workflows-irs/build.gradle‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ dependencies {
1414

1515
// Corda integration dependencies
1616
cordaCompile project(':core')
17+
18+
// only included to control the `DemoClock` as part of the demo application
19+
// normally `:node` should not be depended on in any CorDapps
20+
cordaCompile project(':node')
1721

1822
// Cordapp dependencies
1923
// Specify your cordapp's dependencies below, including dependent cordapps

samples/irs-demo/cordapp/workflows-irs/src/test/kotlin/net/corda/irs/flows/UpdateBusinessDayFlow.kt renamed to samples/irs-demo/cordapp/workflows-irs/src/main/kotlin/net.corda.irs/flows/UpdateBusinessDayFlow.kt

File renamed without changes.

samples/irs-demo/web/src/test/kotlin/net/corda/irs/web/api/InterestRatesSwapDemoAPI.kt renamed to samples/irs-demo/web/src/main/kotlin/net/corda/irs/web/api/InterestRatesSwapDemoAPI.kt

File renamed without changes.

‎samples/irs-demo/web/src/main/resources/static/view/deal.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</tr>
2121
<tr class="center aligned">
2222
<td>Trade ID</td>
23-
<td>{{deal.ref}}</td>
23+
<td>{{deal.common.tradeID}}</td>
2424
</tr>
2525
<tr class="center aligned">
2626
<td>Valuation Date</td>

‎samples/irs-demo/web/src/main/resources/static/view/home.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ <h3 class="ui horizontal divider header">
4545
</tr>
4646
</thead>
4747
<tbody>
48-
<tr class="center aligned" ng-repeat="deal in deals" id="deal-{{deal.ref}}">
49-
<td><a href="#/deal/{{deal.ref}}">{{deal.ref}}</a></td>
48+
<tr class="center aligned" ng-repeat="deal in deals" id="deal-{{deal.common.tradeID}}">
49+
<td><a href="#/deal/{{deal.common.tradeID}}">{{deal.common.tradeID}}</a></td>
5050
<td class="single line">{{renderX500Name(deal.fixedLeg.fixedRatePayer)}}</td>
5151
<td class="single line">{{deal.fixedLeg.notional}}</td>
5252
<td class="single line">{{renderX500Name(deal.floatingLeg.floatingRatePayer)}}</td>

0 commit comments

Comments
 (0)