[macros]: reexport proc macros to work around explicit third party dependency #1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the need to explicitly to load the dependencies of the proc macros into the namespace at the expansion site.
To do this, we needed to employ 2 tricks:
proc-macroscrate that holds the proc macros, but expands third party dependencies as::commonware_macros::<item>. This is because crates configured withproc-macro = trueare only allowed to reexport items marked#[proc_macro].macrosre-export the third party dependencies and the proc macros.Finally, to ensure that the proc macros tests work without having the 3rd party items in the namespace, we need to introduce a crate
macros-testand move all integration tests there. Sincecommonware-macroshas all third party dependencies in its namespace (since it reexports them), it cannot ensure that the expanded code works without it.