Fully encapsulate freeimage in bitmap library #2332
Merged
+330
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
added a commit
that referenced
this pull request
Jan 8, 2024
* Fully encapsulate freeimage in bitmap library * d * d * d * d * d
ahojnnes
added a commit
that referenced
this pull request
Jan 8, 2024
ahojnnes
added a commit
that referenced
this pull request
May 27, 2024
* Stable version 3.9 release (#2319) * Version 3.9 changelog (#2325) * Fully encapsulate freeimage in bitmap library (#2332) (#2334) * Fully encapsulate freeimage in bitmap library * d * d * d * d * d * Patch release 3.9.1 (#2335) * ENH: making LSD optional * MAINT: merge master * MAINT: merge master * MAINT: formatting --------- Co-authored-by: Johannes Schönberger <[email protected]> Co-authored-by: Jan Zapletal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids propagating the FreeImage target to other libraries, as it is now defined as a private link library. As a side effect, this circumvents a bug in CMake, as FreeImage defines /EHsc flags as a public compiler flag that is not correctly propagated by CMake to the nvcc.