remove node:module polyfills (#10431)

anonrig · vicb · web-flow · commit f656d1a2da77 · 2025-08-28T14:02:08.000+02:00
Co-authored-by: Victor Berchet &lt;victor@suumit.com&gt;
diff --git a/.changeset/cruel-terms-smell.md b/.changeset/cruel-terms-smell.md
@@ -0,0 +1,5 @@
+---
+"@cloudflare/unenv-preset": patch
+---
+
+Remove node:module polyfills
diff --git a/packages/unenv-preset/package.json b/packages/unenv-preset/package.json
@@ -49,7 +49,7 @@
 	},
 	"peerDependencies": {
 		"unenv": "2.0.0-rc.19",
-		"workerd": "^1.20250816.0"
+		"workerd": "^1.20250823.0"
 	},
 	"peerDependenciesMeta": {
 		"workerd": {
diff --git a/packages/unenv-preset/src/preset.ts b/packages/unenv-preset/src/preset.ts
@@ -30,6 +30,7 @@ const nativeModules = [
 	"path/posix",
 	"path/win32",
 	"querystring",
+	"module",
 	"stream",
 	"stream/consumers",
 	"stream/promises",
@@ -44,7 +45,7 @@ const nativeModules = [
 ];
 
 // Modules implemented via a mix of workerd APIs and polyfills.
-const hybridModules = ["console", "crypto", "module", "process", "util"];
+const hybridModules = ["console", "crypto", "process", "util"];
 
 /**
  * Creates the Cloudflare preset for the given compatibility date and compatibility flags
diff --git a/packages/unenv-preset/src/runtime/node/module.ts b/packages/unenv-preset/src/runtime/node/module.ts
diff --git a/packages/wrangler/e2e/unenv-preset/worker/index.ts b/packages/wrangler/e2e/unenv-preset/worker/index.ts
@@ -116,6 +116,7 @@ export const WorkerdTests: Record<string, () => void> = {
 			"path/posix",
 			"path/win32",
 			"querystring",
+			"module",
 			"stream",
 			"stream/consumers",
 			"stream/promises",
@@ -387,4 +388,51 @@ export const WorkerdTests: Record<string, () => void> = {
 			assert.throws(() => fs.openAsBlob("/tmp/sync"), /not implemented/);
 		}
 	},
+
+	async testModule() {
+		const module = await import("node:module");
+		const exportNames = [
+			"createRequire",
+			"enableCompileCache",
+			"findSourceMap",
+			"getCompileCacheDir",
+			"getSourceMapsSupport",
+			"isBuiltin",
+			"register",
+			"runMain",
+			"setSourceMapsSupport",
+			"stripTypeScriptTypes",
+			"syncBuiltinESMExports",
+			"wrap",
+			"flushCompileCache",
+			"findPackageJSON",
+			"_debug",
+			"_findPath",
+			"_initPaths",
+			"_load",
+			"_preloadModules",
+			"_resolveFilename",
+			"_resolveLookupPaths",
+			"_nodeModulePaths",
+			"Module",
+			"SourceMap",
+		];
+
+		for (const name of exportNames) {
+			// @ts-expect-error TS7053
+			assert.strictEqual(typeof module[name], "function");
+		}
+
+		// @ts-expect-error TS2339 Invalid node/types.
+		assert.ok(Array.isArray(module.globalPaths));
+		assert.ok(Array.isArray(module.builtinModules));
+		// @ts-expect-error TS2339 Invalid node/types.
+		assert.strictEqual(typeof module.constants, "object");
+		// @ts-expect-error TS2339 Invalid node/types.
+		assert.strictEqual(typeof module._cache, "object");
+		// @ts-expect-error TS2339 Invalid node/types.
+		assert.strictEqual(typeof module._extensions, "object");
+		// @ts-expect-error TS2339 Invalid node/types.
+		assert.strictEqual(typeof module._pathCache, "object");
+	},
 };
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@cloudflare/unenv-preset": patch
 +---
++
 +Remove node:module polyfills