Bump Go to 1.25.3 #11926
Open
Bump Go to 1.25.3 #11926
+7
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <[email protected]>
The `cutSuffix` function was added to backport the functionality of `strings.CutSuffix` from Go 1.20. Now that we're using Go 1.25, we can safely replace our backport with the standard library function. Our backport was an intact copy/paste of the stdlib implementation, so this change does not alter any behavior. Signed-off-by: Babak K. Shandiz <[email protected]>
Signed-off-by: Babak K. Shandiz <[email protected]>
babakks
reviewed
Oct 31, 2025
Comment on lines
-100
to
-106
| // Backport strings.CutSuffix from Go 1.20. | ||
| func cutSuffix(s, suffix string) (string, bool) { | ||
| if !strings.HasSuffix(s, suffix) { | ||
| return s, false | ||
| } | ||
| return s[:len(s)-len(suffix)], true | ||
| } |
There was a problem hiding this comment.
This was an intact copy/paste of the stdlib implementation (below), so it's safe to just use the stdlib now:
func CutSuffix(s, suffix string) (before string, found bool) {
if !HasSuffix(s, suffix) {
return s, false
}
return s[:len(s)-len(suffix)], true
}There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project's Go version requirement from 1.24 to 1.25 and removes a custom cutSuffix backport function in favor of using the standard library's strings.CutSuffix.
- Upgrades Go version from 1.24 to 1.25 in go.mod
- Replaces custom
cutSuffixfunction withstrings.CutSuffixfrom the standard library - Updates documentation and development environment configurations to reflect the new Go version requirement
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/ghinstance/host.go | Removes custom cutSuffix backport function and uses strings.CutSuffix |
| go.mod | Updates Go version to 1.25.0 and toolchain to go1.25.3 |
| docs/source.md | Updates documentation to require Go 1.25+ |
| docs/install_source.md | Updates installation instructions to require Go 1.25+ |
| .github/CONTRIBUTING.md | Updates contributor prerequisites to require Go 1.25+ |
| .devcontainer/devcontainer.json | Updates dev container image to use Go 1.25 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BagToad
approved these changes
Oct 31, 2025
BagToad
requested changes
Oct 31, 2025
|
Yeah, I've noticed them. Already touched on this in the body:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Go to the latest stable release.
1.25.01.25.3Other changes:
strings.CutSuffixis now dropped in favour of stdlib implementation.The reported vulnerabilities (e.g. here) are false positives. It's because
govluncheckthinks we're importing the latest untaggedcli/clias an external dependency.