hrm, isn't that bitrate clamped properly at this point? If not, shouldn't we fix that instead? :)

Looks like before gcc was introduced, target_bitrate was used in calculation which was always <= max_bitrate.
Here, looks like actual bitrate is used, which can be more than max_bitrate.

UPD: I could misunderstood this, and maybe bitrate should be clamped instead :)

Hmm. My bad. bitrate in this context is estimated bitrate notified by rtpgccbwe. Maybe, you're right and rtpgccbwe should not estimate more than max_bitrate?

@MathieuDuponchelle sorry for confusion. I should have check deeper before doing PR.

Here is what I found.
If do_fec is set to true - rtpgccbwe's max-bitrate will be max-bitrate * 1.5.

So, bitrate in this callback is clamped but with different "max", because it includes the bitrate which is supposed to be used for fec.
I've updated the PR to contain fec check as well.

Let me know what you think. Thanks :)

@thiblahute ? this is all a bit ugly, not sure how to make nicer :)

I think the way to make it nicer would be to have the max-bitrate take FEC into account all the time and then set the encoder bitrate / fec porcentage as needed, what do you think?

I think the way to make it nicer would be to have the max-bitrate take FEC into account all the time and then set the encoder bitrate / fec porcentage as needed, what do you think?

You mean that it should also be the meaning of the prop as exposed to the user? I suppose that's a solution

I think the way to make it nicer would be to have the max-bitrate take FEC into account all the time and then set the encoder bitrate / fec porcentage as needed, what do you think?

You mean that it should also be the meaning of the prop as exposed to the user? I suppose that's a solution

Yes, that is what I mean

@gondaruk , I guess that needs a decision, I say we go with what thibault suggests if you agree :)

Thanks!
Let me work on that and I'll get back :)

Hey @MathieuDuponchelle @thiblahute,
whenever you have a chance, could you please take a look on the update and let me know if it's what you meant or if I misunderstood you?
Thanks!

care to review this one @thiblahute ? :)

@thiblahute @MathieuDuponchelle, whenever you have a chance, could you please take a look?
Thanks :)