Set min/max-rtp-port on ice-agent from webrtcsink property #78
Conversation
|
Hey, I'd rather not start proxying all webrtcbin and friends properties at the webrtcsink level, this can be set instead from a handler for the |
|
Fair enough - good to know this can be done through the consumer-added signal - this worked :) For future reference, the code snippet looks like this: let sink: gst::Bin =
gst::ElementFactory::make_with("webrtcsink", &[("display-name", &display_name)])?
.downcast()
.unwrap();
let cloned_options = options.clone();
sink.connect_closure(
"consumer-added",
false,
glib::closure!(|_webrtcsink: &gst::Element,
consumer_identifier: &str,
webrtcbin: &gst::Element| {
gst::gst_info!(CAT, "Consumer added with id: {}", consumer_identifier);
let webrtc_ice: gst::Object = webrtcbin.try_property("ice-agent").unwrap();
if let Some(min_rtp_port) = cloned_options.min_rtp_port {
gst::gst_info!(CAT, "Setting min rtp port on ice-agent");
webrtc_ice.set_property_from_value("min-rtp-port", &min_rtp_port.to_value());
};
if let Some(max_rtp_port) = cloned_options.max_rtp_port {
gst::gst_info!(CAT, "Setting max rtp port on ice-agent");
webrtc_ice.set_property_from_value("max-rtp-port", &max_rtp_port.to_value());
};
}),
); |
|
@compiaffe if you feel like adding an example for the |
|
Fair enough, I can do that. Would you prefer to have it as a PR that modifies the one example server in this repo or a stand-alone repo just like https://github.com/centricular/webrtcsink-custom-signaller ? |
|
Just a separate example in |
|
FYI, still on my list of things to do.. Might not make it before October... |
No description provided.