-
Notifications
You must be signed in to change notification settings - Fork 437
temporal: add temporal service #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f3ad4a8 to
5248354
Compare
|
I'm open to feedback, particularly about the |
5248354 to
539c18b
Compare
Signed-off-by: Mark Sagi-Kazar <[email protected]>
539c18b to
26c4411
Compare
|
Would this be better compared to the current {
state = {
ephemeral = true|false;
sqlite-pragma = {
# ...
};
};
} |
|
I added a separate section for state config matching the above. |
|
Hm, that Maybe it just needs a retry. |
|
Does temporal run in foreground so it can be properly stopped? |
|
It does, but the shutdown process may not be instantaneous. |
f9d5bea to
55c4666
Compare
Signed-off-by: Mark Sagi-Kazar <[email protected]>
55c4666 to
525895f
Compare
|
I tried changing the port, maybe there is a collision. |
673f55f to
4f2b5db
Compare
|
Apparently, there is something running on that port. Changing the port fixes the problem. I also fixed the script, so hopefully it's going to work now. |
Signed-off-by: Mark Sagi-Kazar <[email protected]>
4f2b5db to
1fc5976
Compare
|
Breaking jobs seem unrelated to me. I think this is ready. |
|
seems related to NixOS/nixpkgs#233265 |
|
Can I get a review on this? Since the breaking builds are unrelated, any chance this can get merged? |
Fixes #632