🐛 v2.2.0 files.includes patterns to not work with exact file paths. #7268
Description
Environment information
CLI:
Version: 2.2.0
Color support: true
Platform:
CPU Architecture: aarch64
OS: macos
Environment:
BIOME_LOG_PATH: unset
BIOME_LOG_PREFIX_NAME: unset
BIOME_CONFIG_PATH: unset
BIOME_THREADS: unset
NO_COLOR: unset
TERM: screen-256color
JS_RUNTIME_VERSION: v22.16.0
JS_RUNTIME_NAME: node
NODE_PACKAGE_MANAGER: npm/11.4.2
Biome Configuration:
Status: Loaded successfully
Path: biome.json
Formatter enabled: true
Linter enabled: true
Assist enabled: true
VCS enabled: true
Workspace:
Open Documents: 0
What happened?
After upgrading to biome v2.2.0 the pre-commit hook started including files I'd expect to be ignored. For example, an old configuration like this:
"files": {
"includes": [
"**",
"!src/generated/**"
],
"maxSize": 5000000
},
Now looks like this:
"files": {
"includes": [
"**",
"!src/generated
],
"maxSize": 5000000
},
Previously, a file like src/generated/Foo.ts would correctly be ignored by the precommit hook. Now, the file is checked by biome. This is also reproducible via the command line:
npx biome check src/generated/index.ts
Previously, this correctly says No files were processed in the specified paths.. After v2.2.0, the file will be processed and any errors logged.
A workaround for the issue is using something like !src/generated/**/*.ts in files.includes but that doesn't seem like it should be necessary if I want to ignore all files in a folder.
Expected result
I'd expect the new file pattern without the glob suffix to correctly ignore exact file paths within the folder.
Code of Conduct
- I agree to follow Biome's Code of Conduct