Fix Symfony debug mode in BS5 theme #2168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symfony web debug element uses inline styles that do not adhere to the strict content security policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2031
I've been curious about using debug mode in Symfony so I took a look at this issue. Here is the debug mode bar working in the BS5 theme:
The main issue besides the one fixed in the
DebugPDOclass was the fact that the Symfony debug bar is incompatible with the strict content security policy that's enabled for BS5 themes. Rather than refactor how the debug bar gets rendered, I disabled the CSP when debug mode is on.Other issues addressed
One interesting thing with debug mode is that warnings and errors are rendered directly to the HTML displayed to the user. I wasn't able to fix all of these, but I fixed a number of the most obvious ones that get rendered to the homepage.
The "random" changes I made in this pull request address those errors. For example, adding the
$parsedownvariable toQubitMarkdown.class.phpfixes this error from being rendered: