More LGTM changes.

michaelrsweet · michaelrsweet · commit b31d4ca52509 · 2019-11-18T11:03:28.000-05:00
diff --git a/cups/adminutil.c b/cups/adminutil.c
@@ -1,7 +1,7 @@
 /*
  * Administration utility API definitions for CUPS.
  *
- * Copyright © 2007-2018 by Apple Inc.
+ * Copyright © 2007-2019 by Apple Inc.
  * Copyright © 2001-2007 by Easy Software Products.
  *
  * Licensed under Apache License v2.0.  See the file "LICENSE" for more
@@ -738,13 +738,9 @@ cupsAdminSetServerSettings(
     {
       if (!wrote_browsing)
       {
-	int new_share_printers = (share_printers > 0 ||
-				  (share_printers == -1 &&
-				   old_share_printers > 0));
-
         wrote_browsing = 1;
 
-        if (new_share_printers)
+        if (share_printers)
 	{
 	  const char *localp = cupsGetOption("BrowseLocalProtocols",
 					     num_settings, settings);
diff --git a/scheduler/auth.c b/scheduler/auth.c
@@ -757,7 +757,7 @@ cupsdAuthorize(cupsd_client_t *con)	/* I - Client connection */
     * Decode the authorization string to get the input token...
     */
 
-    len                = (int)strlen(authorization);
+    len                = (int)strlen(authorization) + 0;
     input_token.value  = malloc((size_t)len);
     input_token.value  = httpDecode64_2(input_token.value, &len,
 					authorization);

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/*`
`2`	`2`	`* Administration utility API definitions for CUPS.`
`3`	`3`	`*`
`4`		`- * Copyright © 2007-2018 by Apple Inc.`
	`4`	`+ * Copyright © 2007-2019 by Apple Inc.`
`5`	`5`	`* Copyright © 2001-2007 by Easy Software Products.`
`6`	`6`	`*`
`7`	`7`	`* Licensed under Apache License v2.0. See the file "LICENSE" for more`
`@@ -738,13 +738,9 @@ cupsAdminSetServerSettings(`
`738`	`738`	`{`
`739`	`739`	`if (!wrote_browsing)`
`740`	`740`	`{`
`741`		`- int new_share_printers = (share_printers > 0 \|\|`
`742`		`- (share_printers == -1 &&`
`743`		`- old_share_printers > 0));`
`744`		`-`
`745`	`741`	`wrote_browsing = 1;`
`746`	`742`
`747`		`- if (new_share_printers)`
	`743`	`+ if (share_printers)`
`748`	`744`	`{`
`749`	`745`	`const char *localp = cupsGetOption("BrowseLocalProtocols",`
`750`	`746`	`num_settings, settings);`