Skip to content

Conversation

flpablo
Copy link
Contributor

@flpablo flpablo commented Oct 7, 2025

Please add a meaningful description for your change here

The ReadChangeStreamFromSpanner class was not being picked up by the automatic Python documentation (pydoc) generation used for the Apache Beam website (https://beam.apache.org/releases/pydoc/2.68.0/apache_beam.io.gcp.spanner.html)

This change explicitly adds the class to the relevant array in the Spanner connector's documentation configuration.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

The `ReadChangeStreamFromSpanner` class was not being picked up by the automatic Python documentation (pydoc) generation used for the Apache Beam website.

This change explicitly adds the class to the relevant array in the Spanner connector's documentation configuration.
Copy link
Contributor

Summary of Changes

Hello @flpablo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a documentation gap in the Apache Beam Spanner connector. It ensures that the ReadChangeStreamFromSpanner class, a key component for reading change streams from Google Cloud Spanner, is properly included in the auto-generated Python documentation. This change enhances the usability and discoverability of this functionality for developers leveraging Apache Beam with Spanner.

Highlights

  • Documentation Exposure: The ReadChangeStreamFromSpanner class is now explicitly exposed in the Apache Beam Spanner connector's Python documentation, resolving an issue where it was not being picked up by the automatic documentation generation.
  • Docstring Formatting: Minor indentation adjustments were made to the docstring of the ReadChangeStreamFromSpanner class for consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@flpablo
Copy link
Contributor Author

flpablo commented Oct 9, 2025

assign set of reviewers

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Assigning reviewers:

R: @tvalentyn for label python.
R: @nielm for label spanner.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@nielm nielm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn
Copy link
Contributor

Please fix the docs error:

apache_beam.io.gcp.pubsub.PubSubSourceDescriptor.timestamp_attribute:1: WARNING: duplicate object description of apache_beam.io.gcp.pubsub.PubSubSourceDescriptor.timestamp_attribute, other instance in apache_beam.io.gcp.pubsub, use :no-index: for one of them
2025-10-09T15:57:55.5994272Z /runner/_work/beam/beam/sdks/python/test-suites/tox/pycommon/build/srcs/sdks/python/target/.tox-docs/docs/lib/python3.9/site-packages/apache_beam/io/gcp/spanner.py:docstring of apache_beam.io.gcp.spanner.ReadChangeStreamFromSpanner:11: ERROR: Unexpected indentation.

@tvalentyn
Copy link
Contributor

the logs can be found in the details of the "PythonDocs" test suite that currently fails https://github.com/apache/beam/actions/runs/18380549271/job/52365635645?pr=36428

@flpablo
Copy link
Contributor Author

flpablo commented Oct 11, 2025

@tvalentyn Thanks for the observation.

Fixed the formatting error: https://github.com/apache/beam/actions/runs/18420381156/job/52493179592?pr=36428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants