Skip to content

Conversation

@JSantarelli
Copy link
Contributor

@JSantarelli JSantarelli commented Jun 23, 2021

Objetivo:

  • Plex-card tabeables (incorporación de tabindex en el template del componente)
  • Plex-label identificables como texto (cambia <span> por <p>)

Plus
Se fixea conflicto de color en estado hover de cards outlined.

Test
Navegar a demos de componentes plex-label y plex-card con screen reader (NVDA)

@JSantarelli JSantarelli requested a review from a team as a code owner June 23, 2021 14:13
@JSantarelli JSantarelli requested review from MCele and kroce and removed request for a team June 23, 2021 14:13
@JSantarelli JSantarelli force-pushed the ACC-23 branch 2 times, most recently from fadb395 to aa0db8e Compare July 21, 2021 13:38
Copy link
Contributor

@andrrrl andrrrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprobada la funcionalidad con Voice Over de Apple!

@andrrrl andrrrl merged commit 05437e0 into master Sep 1, 2021
@andrrrl andrrrl deleted the ACC-23 branch September 1, 2021 13:33
liquid36 pushed a commit that referenced this pull request Sep 3, 2021
# [7.19.0](v7.18.2...v7.19.0) (2021-09-03)

### Features

* **accordion:** nueva directiva plAccordion ([#295](#295)) ([83db570](83db570))
* **plex-accordion:** posibilita toggle alternado ([#293](#293)) ([735463d](735463d))
* **plex-card:** tabindex + refactor html plex-label ([#290](#290)) ([05437e0](05437e0))
* **plex-label:** posibilita custom-colors ([#296](#296)) ([8972ce8](8972ce8))
* **plex-slider:** carrousel de elementos ([#292](#292)) ([557cce1](557cce1))
@liquid36
Copy link
Contributor

liquid36 commented Sep 3, 2021

🎉 This PR is included in version 7.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants