feat(hint): permite hint clickeable #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquid36
requested changes
Jul 29, 2020
| this.cdr.detectChanges(); | ||
| } | ||
|
|
||
| // Si el elemento que tiene la directiva [hint] tiene un evento (click), este se ejecutará, guste o no. |
Contributor
There was a problem hiding this comment.
y si no lo tiene? pincha!
Contributor
Author
There was a problem hiding this comment.
jaja ahí se fixeó eso!
Contributor
There was a problem hiding this comment.
Esta bien, pense que hostElement era una componente Angular, pero es un elemento del DOM, así que se ve que siempre tiene click.
liquid36
approved these changes
Aug 5, 2020
| this.cdr.detectChanges(); | ||
| } | ||
|
|
||
| // Si el elemento que tiene la directiva [hint] tiene un evento (click), este se ejecutará, guste o no. |
Contributor
There was a problem hiding this comment.
Esta bien, pense que hostElement era una componente Angular, pero es un elemento del DOM, así que se ve que siempre tiene click.
liquid36
pushed a commit
that referenced
this pull request
Aug 7, 2020
# [6.10.0](v6.9.0...v6.10.0) (2020-08-07) ### Features * **hint:** permite hint clickeable ([#196](#196)) ([591ee09](591ee09))
Contributor
|
🎉 This PR is included in version 6.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El hint usa funcionalidad (click) del elemento padre:
<span hint="actualizar" (click)="actualizar()>Hola Mundo Plano!</span>El ejemplo anterior mostrará un texto con un hint, el cual ejecutará actualizar() al ser clickeado.