CSS Refactor (Remove Bootstrap, Improve Responsiveness) #2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no doubt some regressions, but we'll tackle those later. Pretty happy with the first pass.
I didn't want to get in the weeds with the JS just yet, so for now, I hid some extra elements and tweaked a single return statement; a proper adjustment will happen later.
The navbar list headings were affected by these changes, but they will be fixed another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been kicking this work around in my head since I first raised it in #2751, and I've finally put a bit of work in to see if it was feasible--it appears to be--and unearth some clarifying questions. It actually makes more sense to simplify some CSS before proper template refactoring since it means we'd no longer be restricted by how the chosen styling library works.
I'm sure there are a few sneaky regressions, but I'm not ready to merge this yet, so I can do a proper check at the end--though I am, of course, trying to prevent them as I go! So far, I have:
I'm sure a few obstacles will appear, but all is well at the moment. My question is regarding the "Layout" setting: Would you prefer to keep it and its options even if the panels could more appropriately adapt to available space on their own? I can see the argument behind wanting one extra-wide panel on a large monitor that would otherwise have two or three columns for them. With the refactored CSS, it'd also be possible to let the visitor choose the number of columns they wanted--though, sometimes a few pre-defined options are better than infinity.
This isn't a super consequential question, as the responsiveness is still fairly trivial either way, it'd just change the implementation slightly; will change out of draft status when it's closer to the finish line.
Cheers!