Skip to content

Text modification config #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Text modification config #60

wants to merge 5 commits into from

Conversation

@rodneykinney
Copy link
Member

@rodneykinney rodneykinney commented Oct 19, 2023 •
edited
Loading

Add mixer configuration to trim trailing/leading whitespace from document text, and enforce a minimum document text length. Place these into a new text_modification config object, and move the span_replacements config into it.

@soldni any objections to this backward-incompatible change to config structure?

@rodneykinney rodneykinney changed the title Text modification Config Text modification config Oct 19, 2023
@rodneykinney rodneykinney requested a review from soldni October 19, 2023 17:09
@rodneykinney
Copy link
Member Author

Not sure what's happening with automated tests. Maybe timing out?

make test passes locally, except for the test_download_file Rust test, which also fails on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soldni soldni Awaiting requested review from soldni

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rodneykinney @soldni