Skip to content

[risk=no][no-ticket] Rename package and file name to be consistent with the other services #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[risk=no][no-ticket] Rename package and file name to be consistent with the other services #9199

wants to merge 2 commits into from

Conversation

@tarekmamdouh
Copy link
Collaborator

@tarekmamdouh tarekmamdouh commented Mar 26, 2025 •
edited
Loading

PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@tarekmamdouh tarekmamdouh requested a review from yonghaoy March 26, 2025 18:59
yonghaoy
yonghaoy approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@yonghaoy yonghaoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this PR, but just a random comment:
https://github.com/all-of-us/workbench/blob/main/api/config/config_test.json#L219 wsm config is still pointed to plato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonghaoy yonghaoy yonghaoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarekmamdouh @yonghaoy