Unstable (anthdm#28)

anthdm · web-flow · commit 7b48e18bb26e · 2023-03-13T19:12:47.000+01:00
* Fixed CPU usage caused by polling inboxes

* fixed padding in ggq

* README updates

* doc fix

* more doc updates and fixes

* fixed bug where processes did not cleanup when reaching max restarts

* Added SetOutput for the logger
diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
 test: build
-	go test ./... --race
+	go test ./... -count=1 --race
 
 proto:
 	protoc --go_out=. --go-vtproto_out=.  --go_opt=paths=source_relative --proto_path=. actor/actor.proto
diff --git a/README.md b/README.md
@@ -85,13 +85,14 @@ e.Spawn(newFoo, "foo",
 )
 ```
 
-## Listening to the Eventstream
+## Subscribing and publishing to the Eventstream
 
 ```go
 e := actor.NewEngine()
 
-// Subscribe to a various list of event that are being broadcasted by
-// the engine. But also published by you.
+// Subscribe to a various list of events that are being broadcast by
+// the engine.
+// The eventstream can also be used to publish custom events and notify all of the subscribers..
 eventSub := e.EventStream.Subscribe(func(event any) {
 	switch evt := event.(type) {
 	case *actor.DeadLetterEvent:
@@ -121,7 +122,7 @@ e.SpawnFunc(func(c *actor.Context) {
 time.Sleep(time.Second)
 ```
 
-## Customizing the PID separator
+## Customizing the Engine
 
 ```Go
 cfg := actor.Config{
@@ -132,7 +133,7 @@ e := actor.NewEngine(cfg)
 
 After configuring the Engine with a custom PID Separator the string representation of PIDS will look like this:
 
-```
+```Go
 pid := actor.NewPID("127.0.0.1:3000", "foo", "bar", "baz", "1")
 // 127.0.0.1:3000->foo->bar->baz->1
 ```
@@ -147,15 +148,15 @@ For examples on how to implement custom middleware, check out the middleware fol
 
 You can set the log level of Hollywoods log module:
 
-```
+```Go
 import "github.com/anthdm/hollywood/log
 
 log.SetLevel(log.LevelInfo)
 ```
 
 To disable all logging
 
-```
+```Go
 import "github.com/anthdm/hollywood/log
 
 log.SetLevel(log.LevelPanic)
diff --git a/actor/process.go b/actor/process.go
@@ -132,7 +132,7 @@ func (p *process) tryRestart(v any) {
 		log.Errorw(msg.From, log.M{
 			"error": msg.Err,
 		})
-		time.Sleep(restartDelay)
+		time.Sleep(restartDelay) // TODO: make this configurable
 		p.Start()
 		return
 	}
@@ -145,6 +145,7 @@ func (p *process) tryRestart(v any) {
 			"pid":      p.pid,
 			"restarts": p.restarts,
 		})
+		p.cleanup(nil)
 		return
 	}
 	// Restart the process after its restartDelay
diff --git a/examples/eventstream/main.go b/examples/eventstream/main.go
@@ -12,8 +12,8 @@ func main() {
 	wg := sync.WaitGroup{}
 	wg.Add(1)
 
-	// Subscribe to a various list of event that are being broadcasted by
-	// the engine. But also published by you.
+	// Subscribe to a various list of events that are being broadcast by
+	// the engine, but also published by you.
 	eventSub := e.EventStream.Subscribe(func(event any) {
 		switch evt := event.(type) {
 		case *actor.DeadLetterEvent:
diff --git a/ggq/ggq.go b/ggq/ggq.go
@@ -40,6 +40,7 @@ type GGQ[T any] struct {
 	state      atomic.Uint32
 	_          [cacheLinePadding - unsafe.Sizeof(atomic.Uint32{})]byte
 	isIdling   atomic.Bool
+	_          [cacheLinePadding - unsafe.Sizeof(atomic.Bool{})]byte
 	buffer     []slot[T]
 	_          [cacheLinePadding]byte
 	mask       uint32
diff --git a/log/log.go b/log/log.go
@@ -1,6 +1,10 @@
 package log
 
-import "github.com/sirupsen/logrus"
+import (
+	"io"
+
+	"github.com/sirupsen/logrus"
+)
 
 type M map[string]any
 
@@ -16,6 +20,10 @@ const (
 	LevelPanic
 )
 
+func SetOutput(w io.Writer) {
+	logrus.SetOutput(w)
+}
+
 func SetLevel(level Level) {
 	var l logrus.Level
 	switch level {
