Add ability to process multiple partial folders #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlafroscia
requested changes
Mar 16, 2021
Owner
|
As far as the TypeScript usage goes, this all looks great! |
Co-authored-by: Alex LaFroscia <[email protected]>
Co-authored-by: Alex LaFroscia <[email protected]>
Co-authored-by: Alex LaFroscia <[email protected]>
Contributor
Author
|
I didn't think about the fact that it would break the existing way. What do you think about my conversion? |
alexlafroscia
requested changes
Mar 17, 2021
Owner
alexlafroscia
left a comment
There was a problem hiding this comment.
Functionality-wise, this looks great! Just a few little things I'd like to clean up before merging!
Contributor
Author
|
Thanks for the Feedback. I added a small hint to the README to let users know |
alexlafroscia
approved these changes
Mar 18, 2021
Owner
alexlafroscia
left a comment
There was a problem hiding this comment.
This looks great! Thanks again for putting together this PR!
I’ll get a release cut with this feature today 👍
Owner
|
Just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my first time doing ts, so bare with me 😬