chore: fix ci & tests (electron#1870)

Toinane · web-flow · commit ecb88ce20238 · 2021-08-26T01:13:15.000+02:00
diff --git a/script/readmes.js b/script/readmes.js
@@ -37,27 +37,8 @@ console.log(
 )
 
 appsToUpdate.forEach((app) => {
-  limiter.schedule(getReadme, app)
-})
-
-limiter.on('idle', () => {
-  fs.writeFileSync(outputFile, JSON.stringify(output, null, 2))
-  console.log(`Done fetching README files.\nWrote ${outputFile}`)
-  process.exit()
-})
-
-function getReadme(app) {
-  const { user: owner, repo } = parseGitUrl(app.repository)
-  const opts = {
-    owner: owner,
-    repo: repo,
-    headers: {
-      Accept: 'application/vnd.github.v3.html',
-    },
-  }
-
-  return github.repos
-    .get(opts)
+  limiter
+    .schedule(getReadme, app)
     .then((repository) => {
       return repository.data.default_branch
     })
@@ -70,8 +51,8 @@ function getReadme(app) {
       return
     })
     .then((defaultBranch) => {
-      github.repos
-        .getReadme(opts)
+      limiter
+        .schedule(getReadme, app, defaultBranch)
         .then((release) => {
           console.log(`${app.slug}: got latest README`)
           output[app.slug] = {
@@ -92,6 +73,31 @@ function getReadme(app) {
           }
         })
     })
+})
+
+limiter.on('idle', () => {
+  setTimeout(() => {
+    fs.writeFileSync(outputFile, JSON.stringify(output, null, 2))
+    console.log(`Done fetching README files.\nWrote ${outputFile}`)
+    process.exit()
+  }, 1000)
+})
+
+function getReadme(app, defaultBranch) {
+  const { user: owner, repo } = parseGitUrl(app.repository)
+  const opts = {
+    owner: owner,
+    repo: repo,
+    headers: {
+      Accept: 'application/vnd.github.v3.html',
+    },
+  }
+
+  if (defaultBranch) {
+    return github.repos.getReadme(opts)
+  }
+
+  return github.repos.get(opts)
 }
 
 function cleanReadme(readme, defaultBranch, app) {
diff --git a/script/releases.js b/script/releases.js
@@ -31,16 +31,38 @@ console.log(
 
 appsWithRepos.forEach((app) => {
   if (shouldUpdateAppReleaseData(app)) {
-    limiter.schedule(getLatestRelease, app)
+    limiter
+      .schedule(getLatestRelease, app)
+      .then((release) => {
+        console.log(`${app.slug}: got latest release`)
+        output[app.slug] = {
+          latestRelease: release.data,
+          latestReleaseFetchedAt: new Date(),
+        }
+      })
+      .catch((err) => {
+        console.error(`${app.slug}: no releases found`)
+        output[app.slug] = {
+          latestRelease: null,
+          latestReleaseFetchedAt: new Date(),
+        }
+        if (err.status !== 404) console.error(err)
+      })
   } else {
     output[app.slug] = oldReleaseData[app.slug]
   }
 })
 
+limiter.on('error', (err) => {
+  console.error(err)
+})
+
 limiter.on('idle', () => {
-  fs.writeFileSync(outputFile, JSON.stringify(output, null, 2))
-  console.log(`Done fetching release data.\nWrote ${outputFile}`)
-  process.exit()
+  setTimeout(() => {
+    fs.writeFileSync(outputFile, JSON.stringify(output, null, 2))
+    console.log(`Done fetching release data.\nWrote ${outputFile}`)
+    process.exit()
+  }, 1000)
 })
 
 function shouldUpdateAppReleaseData(app) {
@@ -60,21 +82,5 @@ function getLatestRelease(app) {
     },
   }
 
-  return github.repos
-    .getLatestRelease(opts)
-    .then((release) => {
-      console.log(`${app.slug}: got latest release`)
-      output[app.slug] = {
-        latestRelease: release.data,
-        latestReleaseFetchedAt: new Date(),
-      }
-    })
-    .catch((err) => {
-      console.error(`${app.slug}: no releases found`)
-      output[app.slug] = {
-        latestRelease: null,
-        latestReleaseFetchedAt: new Date(),
-      }
-      if (err.code !== 404) console.error(err)
-    })
+  return github.repos.getLatestRelease(opts)
 }
diff --git a/test/machine-data.js b/test/machine-data.js
@@ -4,6 +4,7 @@ import isHexColor from 'is-hexcolor'
 import categories from '../categories.js'
 import { expect } from 'chai'
 import path from 'path'
+import yaml from 'js-yaml'
 import { _dirname } from '../lib/dirname.js'
 import appsWithRepos from '../lib/apps-with-github-repos.js'
 
@@ -19,12 +20,30 @@ describe('machine-generated app data (exported by the module)', () => {
   it('has the same number of apps as the apps directory', () => {
     const slugs = fs
       .readdirSync(path.join(_dirname(import.meta), '../apps'))
-      .filter((filename) => {
-        return fs
+      .filter((filename) =>
+        fs
           .statSync(path.join(_dirname(import.meta), `../apps/${filename}`))
           .isDirectory()
+      )
+      .filter((filename) => {
+        const yamlFile = path.join(
+          _dirname(import.meta),
+          `../apps/${filename}/${filename}.yml`
+        )
+        const meta = yaml.load(fs.readFileSync(yamlFile))
+
+        if (meta.disabled) {
+          return false
+        }
+
+        return true
       })
 
+    const generatedSlugs = apps.map((app) => app.slug)
+    const missingApps = slugs.filter((slug) => !generatedSlugs.includes(slug))
+    if (missingApps)
+      console.log('missings theses apps from generated json:', missingApps)
+
     expect(apps.length).to.be.above(100)
     expect(apps.length).to.equal(slugs.length)
   })
@@ -143,34 +162,6 @@ describe('machine-generated app data (exported by the module)', () => {
       )
     })
   })
-
-  // it('rewrites relative image source tags', () => {
-  //   const beaker = apps.find((app) => app.slug === 'beaker-browser')
-  //   const local = '<img src="build/icons/256x256.png"'
-  //   const remote =
-  //     '<img src="https://github.com/beakerbrowser/beaker/raw/master/build/icons/256x256.png"'
-
-  //   expect(beaker.readmeOriginal).to.include(local)
-  //   expect(beaker.readmeOriginal).to.not.include(remote)
-
-  //   expect(beaker.readmeCleaned).to.not.include(local)
-  //   expect(beaker.readmeCleaned).to.include(remote)
-  // })
-
-  // it('rewrites relative link hrefs', () => {
-  //   const app = apps.find(
-  //     (app) => app.slug === 'google-play-music-desktop-player'
-  //   )
-  //   const local = 'href="docs/PlaybackAPI.md"'
-  //   const remote =
-  //     'href="https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/master/docs/PlaybackAPI.md"'
-
-  //   expect(app.readmeOriginal).to.include(local)
-  //   expect(app.readmeOriginal).to.not.include(remote)
-
-  //   expect(app.readmeCleaned).to.not.include(local)
-  //   expect(app.readmeCleaned).to.include(remote)
-  // })
 })
 
 describe('machine-generated category data (exported by the module)', () => {
