Aliases can be duplicated between different sub commands (#419)

lespea · web-flow · commit 958a344920f0 · 2024-03-15T06:17:27.000+11:00
Make sure we remove all the aliases from the seenFlags tracker just like we do with other flags/short flags
diff --git a/build.go b/build.go
@@ -170,6 +170,9 @@ MAIN:
 		if flag.Short != 0 {
 			delete(seenFlags, "-"+string(flag.Short))
 		}
+		for _, aflag := range flag.Aliases {
+			delete(seenFlags, "--"+aflag)
+		}
 	}
 
 	if err := validatePositionalArguments(node); err != nil {
diff --git a/kong_test.go b/kong_test.go
@@ -1340,6 +1340,20 @@ func TestDuplicateAliases(t *testing.T) {
 	assert.EqualError(t, err, "<anonymous struct>.Flag2: duplicate flag --flag")
 }
 
+func TestSubCommandAliases(t *testing.T) {
+	type SubC struct {
+		Flag1 string `aliases:"flag"`
+	}
+
+	cli1 := struct {
+		Sub1 SubC `cmd:"sub1"`
+		Sub2 SubC `cmd:"sub2"`
+	}{}
+
+	_, err := kong.New(&cli1)
+	assert.NoError(t, err, "dupe aliases shouldn't error if they're in separate sub commands")
+}
+
 func TestDuplicateAliasLong(t *testing.T) {
 	cli2 := struct {
 		Flag  string ``

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,9 @@ MAIN:`
`170`	`170`	`if flag.Short != 0 {`
`171`	`171`	`delete(seenFlags, "-"+string(flag.Short))`
`172`	`172`	`}`
	`173`	`+ for _, aflag := range flag.Aliases {`
	`174`	`+ delete(seenFlags, "--"+aflag)`
	`175`	`+ }`
`173`	`176`	`}`
`174`	`177`
`175`	`178`	`if err := validatePositionalArguments(node); err != nil {`