User gets upgrade prompt #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fixed merge conficts, adds semver dependency, all the fun code is in |
alarner
reviewed
Oct 12, 2016
| #!/usr/bin/env node --use_strict | ||
| let path = require('path'); | ||
| let steps = require('./steps'); | ||
| let check = require('./check'); |
Owner
There was a problem hiding this comment.
Could we name this something different than check for clarity. Maybe checkVersion?
alarner
reviewed
Oct 12, 2016
| `; | ||
| ` + (current ? '' : 'Be Aware your perky-cli version is outdated, there may be differences with the docs'); |
Owner
There was a problem hiding this comment.
With ES6 string interpolation you could stick this right inside of the previous message instead of concatenating. Also there's a small typo (perky-cli) and we should notify them how to upgrade their perk-cli if they want to:
eg.
return `
Your new project has successfully been created in ${dirPath}
You should run:
cd ${dirPath} && npm install
While dependencies for your new perk app are installing you can check
out more info on how to use all the great features of perk at:
http://perkframework.com/v1/guides/getting-started-os-x.html
${current ? '' : 'Be Aware your perk-cli version is outdated, there may be differences with the docs. To upgrade run `npm install-g perk-cli`'}
`;
Owner
There was a problem hiding this comment.
Looking forward to getting this deployed. Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text on this is open to change, nice little prompt both before and after the text dump when running the perk command