Add the ability to get the CWD of the foreground process on OpenBSD. #8736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpulvis
reviewed
Oct 31, 2025
chrisduerr
requested changes
Oct 31, 2025
Member
chrisduerr
left a comment
There was a problem hiding this comment.
Still missing a changelog entry.
9013df2 to
922582e
Compare
Contributor
Author
|
Hopefully I've addressed your comments in the new commit. |
kchibisov
previously requested changes
Nov 1, 2025
922582e to
233ce09
Compare
Contributor
Author
|
@kchibisov Hopefully fixed. |
nixpulvis
reviewed
Nov 1, 2025
chrisduerr
requested changes
Nov 1, 2025
bfe2b08 to
98a5560
Compare
Contributor
Author
|
@chrisduerr Applied your suggestions. Thanks! |
chrisduerr
requested changes
Nov 1, 2025
Member
chrisduerr
left a comment
There was a problem hiding this comment.
One last thing, after that LGTM.
OpenBSD doesn't have `proc`, but the necessary information can be obtained via `sysctl`.
98a5560 to
5fb137d
Compare
chrisduerr
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #8721 (comment). Tested working on OpenBSD; tested that this still builds correctly on Linux (though I can't actually test a running Alacritty on Linux).
Note: OpenBSD doesn't have
proc, but the necessary information can be obtained viasysctl.