Skip to content

MenuGroup onPress is never fired #1207

@micaelomota

Description

@micaelomota

🐛 Bug Report

When using MenuGroups, any TouchableOpacityProps were supposed to be accepted, but if you pass onPress it will never be fired because it will be overridden in the render function.

TouchableOpacityProps reference

* @property {TouchableOpacityProps} ...TouchableOpacityProps - Any props applied to TouchableOpacity component.

Render reference

To Reproduce

Steps to reproduce the behavior:

  1. Create a Menu and add a MenuGroup item
  2. Add the TouchableOpacityProps
<Menu>
 <MenuGroup
     onPressIn={() => console.log("onPressIn")}
     onPress={() => console.log("onPress")}
     onPressOut={() => console.log("onPressOut")}>
 // ...

Expected behavior

When you tap on the MenuGroup item we expected to see the following in the console

onPressIn
onPress
onPressOut

But you only see

onPressIn
onPressOut

Link to runnable example or repository (highly encouraged)

https://snack.expo.io/3JHB_ESV6

UI Kitten and Eva version

Package Version
@eva-design/eva 2.0.0
@ui-kitten/components 5.0.0

Environment information

System:
    OS: macOS 10.15.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
    Yarn: 1.22.4 - ~/.yarn/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 28, 29, 30
      Build Tools: 28.0.3, 29.0.3, 30.0.1
      System Images: android-30 | Google Play Intel x86 Atom
  IDEs:
    Android Studio: 4.0 AI-193.6911.18.40.6514223
    Xcode: 11.6/11E708 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.11.0 => 16.11.0 
    react-native: 0.62.2 => 0.62.2 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions