You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was checking out the latest demo from viaduct-graphql a few days ago and they don't compile.
The reason is that they had changes for a viaduct 0.4.0 release that has not happened yet while the changes are not backward compatible. It appears that the check in are synced from a bot and my guess is that it is syncing from main brnach. Also the main branch demoapp changes appear missed updating gradle.properties's viaduct version to 0.4.0. The testing of those demo app within viaduct project appears using the viaduct in the same build while those from viaduct-graphql really depend on the right version to be set in gradle.properties file.
I would suggest we create a branch like "published-demo" where the bot sync from there. the main branch can update the demo to the latest viaduct api change but "published-demo" should only cherry pick the demo changes AFTER those changes in Viaduct lib code are built and published to maven central for the next version.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I was checking out the latest demo from viaduct-graphql a few days ago and they don't compile.
The reason is that they had changes for a viaduct 0.4.0 release that has not happened yet while the changes are not backward compatible. It appears that the check in are synced from a bot and my guess is that it is syncing from main brnach. Also the main branch demoapp changes appear missed updating gradle.properties's viaduct version to 0.4.0. The testing of those demo app within viaduct project appears using the viaduct in the same build while those from viaduct-graphql really depend on the right version to be set in gradle.properties file.
I would suggest we create a branch like "published-demo" where the bot sync from there. the main branch can update the demo to the latest viaduct api change but "published-demo" should only cherry pick the demo changes AFTER those changes in Viaduct lib code are built and published to maven central for the next version.
Beta Was this translation helpful? Give feedback.
All reactions