Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openrewrite/rewrite-logging-frameworks
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.7.0
Choose a base ref
...
head repository: openrewrite/rewrite-logging-frameworks
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.8.0
Choose a head ref
  • 7 commits
  • 12 files changed
  • 6 contributors

Commits on Apr 25, 2025

  1. Configuration menu
    Copy the full SHA
    5aea6a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2025

  1. Configuration menu
    Copy the full SHA
    e828392 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2025

  1. Wrap logging statements with method invocation arguments in an if ena…

    …bled conditional (#215)
    
    * draft
    
    * Do not call `toString` on LST element used in JavaTemplate
    
    * Update src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    
    * Update src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    
    * Update src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggersTest.java
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    
    * Update src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggersTest.java
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    
    * Update src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java
    
    Co-authored-by: Tim te Beek <[email protected]>
    
    * Added support for other levels
    
    * Added after Visitor to bundle log statements
    
    * Renamed executionContext
    
    * Fixed bug where unrelated if's were discarded
    
    * Use textblock in CsvSource
    
    * Keep formatting
    
    * Removed star imports
    
    * fixed small issue
    
    * Minor improvements, added comments to accumulator
    
    * Added javadoc explaining mechanism in Accumulator
    
    * fixed typos
    
    * Fixed newline
    
    * added braces
    
    ---------
    
    Co-authored-by: Tim te Beek <[email protected]>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    3 people authored Apr 30, 2025
    Configuration menu
    Copy the full SHA
    5d1b4cd View commit details
    Browse the repository at this point in the history
  2. Add WrapExpensiveLogStatementsInConditionals to Slf4jBestPractices (

    #216)
    
    * Add `InexpensiveSLF4JLoggers` to `Slf4jBestPractices`
    
    * Apply formatter & polish
    
    * Update examples as suggested
    
    * Extract separate named visitor that encapsulates helper methods
    
    * Drop WARN/ERROR from InexpensiveSLF4JLoggers
    
    * Adopt `firstEnclosing` instead of catching exception
    
    * Rename and adjust description
    
    * Remove need for `isAcceptable`
    
    * Update examples following rename
    timtebeek authored Apr 30, 2025
    Configuration menu
    Copy the full SHA
    d1e0c69 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2025

  1. Configuration menu
    Copy the full SHA
    4d731d9 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2025

  1. Use classpathFromResources in InexpensiveLogStatements (#217)

    * Use classpathFromResources
    
    * Match `parserClasspath` in using `slf4j-api-2.+`
    
    ---------
    
    Co-authored-by: Tim te Beek <[email protected]>
    JohannisK and timtebeek authored May 6, 2025
    Configuration menu
    Copy the full SHA
    05ebc23 View commit details
    Browse the repository at this point in the history
  2. Make inexpensive log statements less noisy (#218)

    * Scoped autoFormat better
    JohannisK authored May 6, 2025
    Configuration menu
    Copy the full SHA
    167595a View commit details
    Browse the repository at this point in the history
Loading