Skip to content

[translator/azurelogs] Azure logs fix resource attributes #39571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 2, 2025
Merged

[translator/azurelogs] Azure logs fix resource attributes #39571

merged 10 commits into from
May 2, 2025

Conversation

constanca-m
Copy link
Contributor

Description

The issue for this PR was first reported here: #39186.

Currently, the resource logs have no attributes. This means that all records are supposedly the same, which is not true.

This PR adds attributes to the resources.

Link to tracking issue

Relates #39186.

Testing

Unit tests fixed.

@constanca-m constanca-m requested review from a team and atoulme as code owners April 22, 2025 22:49
atoulme
atoulme reviewed Apr 24, 2025
View reviewed changes
@constanca-m constanca-m requested a review from atoulme April 27, 2025 16:00
MikeGoldsmith
MikeGoldsmith suggested changes Apr 28, 2025
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right choice but does have user facing changes that we should highlight (eg some log record attributes are moved to resource attributes). Also, I don't think we should remove event.name attribute yet.

Consumers of these attributes may depend on their names and locations. Maybe we dual write them for a short time, or add a feature flag to control behaviour?

@constanca-m
Copy link
Contributor Author

constanca-m commented Apr 28, 2025 •
edited
Loading

Thanks @MikeGoldsmith @cparkins @atoulme . I am not totally convinced on this event.name to be honest, but I put it back again as a resource attribute.

@MikeGoldsmith Can you tell me more about the semantic conventions you linked for azure? Is this something that is in use in general, or just part of this translator? Reason I ask is that some of these attributes should not be there (for example properties - see