Skip to content

Add Cluster Info to Redis Receiver #38285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Add Cluster Info to Redis Receiver #38285

wants to merge 11 commits into from

Conversation

akstron
Copy link
Contributor

@akstron akstron commented Mar 1, 2025

Description

Adding implementation to retrieve cluster info.

Link to tracking issue

Fixes: #38117

Testing

Not tested yet

@github-actions github-actions bot added the receiver/redis Redis related issues label Mar 1, 2025
@github-actions github-actions bot requested review from dmitryax and hughesjj March 1, 2025 13:23
@akstron
Copy link
Contributor Author

akstron commented Mar 1, 2025

Creating this draft PR to get feedback if I am on the right track. Next set of commits would include extraction of all the data included here: https://redis.io/docs/latest/commands/cluster-info/

akstron added 2 commits March 10, 2025 21:30
@akstron
Added cluster info retrieval impl
492dade 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
Added cluster slots assigned metric
f4470d9 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron akstron force-pushed the aloksingh/redis-receiver-cluster-info branch from 4c5458c to f4470d9 Compare March 10, 2025 16:00
akstron and others added 5 commits March 16, 2025 19:18
@akstron
pr fixes
a277bc8 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
fix test failure
3d0379e 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
add flag
9bc44b6 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
lint fix
4001cf9 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
Merge branch 'main' into aloksingh/redis-receiver-cluster-info
27d2070
@akstron akstron marked this pull request as ready for review March 16, 2025 16:39
@akstron akstron requested a review from a team as a code owner March 16, 2025 16:39
@akstron
Copy link
Contributor Author

akstron commented Mar 16, 2025

Hi @dmitryax , can you please provide feedback on the current code structure?

atoulme
atoulme reviewed Mar 17, 2025
View reviewed changes
@atoulme atoulme marked this pull request as draft March 17, 2025 22:33
@atoulme
Copy link
Contributor

atoulme commented Mar 17, 2025

Please add a changelog. Please review my comment and change default behavior to disabled.

akstron added 2 commits March 18, 2025 19:16
@akstron
Added chlog
e7f60de 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
disabled by default
9563cee 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
Copy link
Contributor Author

akstron commented Mar 18, 2025

Hi @atoulme , addressed your comments. Thanks

@atoulme atoulme marked this pull request as ready for review March 24, 2025 22:37
@atoulme
Copy link
Contributor

atoulme commented Mar 24, 2025

@dmitryax @hughesjj please review as codeowners

@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Closed
This was referenced Apr 1, 2025
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the