-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
Description
Component(s)
pkg/stanza
What happened?
Description
Some benchmark tests in pkg/stanza
fail. Here's the test cases.
pkg/stanza/adapter:
- BenchmarkFromPdataConverter
- BenchmarkReadLine
- BenchmarkParseAndMap
pkg/stanza/operator/transformer/recombine:
- BenchmarkRecombine
- BenchmarkRecombineLimitTrigger
Steps to Reproduce
cd pkg/stanza
go test -bench=. ./...
Expected Result
The benchmarks should be fixed or removed if no longer needed.
Actual Result
The benchmarks failed.
Collector version
Environment information
Environment
OS: Sequoia 15.5
Compiler(if manually compiled): go1.24.4 darwin/arm64 (Apple M4 Max)
OpenTelemetry Collector configuration
N/A
Log output
--- FAIL: BenchmarkFromPdataConverter/worker_count=1
frompdataconverter_test.go:153:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/frompdataconverter_test.go:153
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:219
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:245
/opt/homebrew/Cellar/go/1.24.4/libexec/src/runtime/asm_arm64.s:1223
Error: "[0x140ee047ec0]" should have 250000 item(s), but has 1
Test: BenchmarkFromPdataConverter/worker_count=1
--- FAIL: BenchmarkFromPdataConverter/worker_count=2
frompdataconverter_test.go:153:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/frompdataconverter_test.go:153
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:219
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:245
/opt/homebrew/Cellar/go/1.24.4/libexec/src/runtime/asm_arm64.s:1223
Error: "[0x140ee047ec0]" should have 250000 item(s), but has 1
Test: BenchmarkFromPdataConverter/worker_count=2
--- FAIL: BenchmarkFromPdataConverter/worker_count=4
frompdataconverter_test.go:153:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/frompdataconverter_test.go:153
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:219
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:245
/opt/homebrew/Cellar/go/1.24.4/libexec/src/runtime/asm_arm64.s:1223
Error: "[0x14003bac000]" should have 250000 item(s), but has 1
Test: BenchmarkFromPdataConverter/worker_count=4
--- FAIL: BenchmarkFromPdataConverter/worker_count=6
frompdataconverter_test.go:153:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/frompdataconverter_test.go:153
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:219
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:245
/opt/homebrew/Cellar/go/1.24.4/libexec/src/runtime/asm_arm64.s:1223
Error: "[0x140ee047ec0]" should have 250000 item(s), but has 1
Test: BenchmarkFromPdataConverter/worker_count=6
--- FAIL: BenchmarkFromPdataConverter/worker_count=8
frompdataconverter_test.go:153:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/frompdataconverter_test.go:153
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:219
/opt/homebrew/Cellar/go/1.24.4/libexec/src/testing/benchmark.go:245
/opt/homebrew/Cellar/go/1.24.4/libexec/src/runtime/asm_arm64.s:1223
Error: "[0x140ee047ec0]" should have 250000 item(s), but has 1
Test: BenchmarkFromPdataConverter/worker_count=8
--- FAIL: BenchmarkFromPdataConverter
...
--- FAIL: BenchmarkReadLine
receiver_test.go:285:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/receiver_test.go:285
Error: Received unexpected error:
'' unsupported type 'file_input'
Test: BenchmarkReadLine
--- FAIL: BenchmarkParseAndMap
receiver_test.go:369:
Error Trace: /Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/adapter/receiver_test.go:369
Error: Received unexpected error:
unsupported type 'file_input'
Test: BenchmarkParseAndMap
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 28873209 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:171 +0x94
created by github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1 in goroutine 28872828
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:165 +0x60
Goroutine 23815897 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:171 +0x94
created by github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1 in goroutine 23815515
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:165 +0x60
Goroutine 26366477 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:171 +0x94
created by github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1 in goroutine 26356999
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:165 +0x60
Goroutine 2567998 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:171 +0x94
created by github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1 in goroutine 2565493
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:165 +0x60
Goroutine 24826320 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:171 +0x94
created by github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1 in goroutine 23816817
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:165 +0x60
Goroutine 2566092 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:171 +0x94
created by github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1 in goroutine 2568291
/Users/ray.kang/github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex/cache.go:165 +0x60
Goroutine 20739796 in state select, with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1 on top of the stack:
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/parser/regex.(*atomicLimiter).init.func1.1()
(omitted as it is too long)
Additional context
Found while working on #43026
Tip
React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1
or me too
, to help us triage it. Learn more here.
andrzej-stencel and VihasMakwana