[chore][pkg/stanza] - Fix Flaky test TestMatcher (#36640)

VihasMakwana · web-flow · commit 7abf152a6bce · 2024-12-03T09:23:45.000-08:00
Fixes #36623 We're using a map to store groups and we then do a `for .. range` over keys. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/6119d51a5a85565c409bb225027d6d1ab353aecc/pkg/stanza/fileconsumer/matcher/matcher.go#L200-L206 For maps, the ordering of keys is not guaranteed. Hence, the check fails. We should instead check with `assert.ElementsMatch` (which was previously the case, but #36518 changed it to `assert.Equal`)
diff --git a/pkg/stanza/fileconsumer/matcher/matcher_test.go b/pkg/stanza/fileconsumer/matcher/matcher_test.go
@@ -853,7 +853,7 @@ func TestMatcher(t *testing.T) {
 			} else {
 				assert.NoError(t, err)
 			}
-			assert.Equal(t, tc.expected, files)
+			assert.ElementsMatch(t, tc.expected, files)
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -853,7 +853,7 @@ func TestMatcher(t *testing.T) {`
`853`	`853`	`} else {`
`854`	`854`	`assert.NoError(t, err)`
`855`	`855`	`}`
`856`		`- assert.Equal(t, tc.expected, files)`
	`856`	`+ assert.ElementsMatch(t, tc.expected, files)`
`857`	`857`	`})`
`858`	`858`	`}`
`859`	`859`	`}`