[chore] enable exhaustive option explicit-exhaustive-switch (#24412)

fatsheep9146 · web-flow · commit c55822fe72d5 · 2023-07-22T09:54:23.000-04:00
diff --git a/.golangci.yml b/.golangci.yml
@@ -123,6 +123,9 @@ linters-settings:
           files:
             - "!**/*_test.go"
 
+  exhaustive:
+    explicit-exhaustive-switch: true
+
 linters:
   enable:
     - depguard
@@ -153,141 +156,4 @@ issues:
         - gosec
     - text: "G402:"
       linters:
-        - gosec
-    # Following exclude-rules are used to exclude the existing components which do not pass exhaustive lint,
-    # in order to enable the exhaustive lint check.
-    # We should not add more exclude-rules.
-    # The progress of solving existing exclude-rules will be tracked in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266
-    - path: fluentforwardreceiver
-      linters:
-        - exhaustive
-    - path: prometheusreceiver
-      linters:
-        - exhaustive
-    - path: deltatorateprocessor
-      linters:
-        - exhaustive
-    - path: filterprocessor
-      linters:
-        - exhaustive
-    - path: metricsgenerationprocessor
-      linters:
-        - exhaustive
-    - path: metricstransformprocessor
-      linters:
-        - exhaustive
-    - path: probabilisticsamplerprocessor
-      linters:
-        - exhaustive
-    - path: servicegraphprocessor
-      linters:
-        - exhaustive
-    - path: resourcedetectionprocessor
-      linters:
-        - exhaustive
-    - path: tailsamplingprocessor
-      linters:
-        - exhaustive
-    - path: transformprocessor
-      linters:
-        - exhaustive
-    - path: alibabacloudlogserviceexporter
-      linters:
-        - exhaustive
-    - path: awsemfexporter
-      linters:
-        - exhaustive
-    - path: awsxrayexporter
-      linters:
-        - exhaustive
-    - path: azuremonitorexporter
-      linters:
-        - exhaustive
-    - path: azuredataexplorerexporter
-      linters:
-        - exhaustive
-    - path: carbonexporter
-      linters:
-        - exhaustive
-    - path: coralogixexporter
-      linters:
-        - exhaustive
-    - path: datasetexporter
-      linters:
-        - exhaustive
-    - path: elasticsearchexporter
-      linters:
-        - exhaustive
-    - path: googlecloudpubsubexporter
-      linters:
-        - exhaustive
-    - path: instanaexporter
-      linters:
-        - exhaustive
-    - path: jaegerthrifthttpexporter
-      linters:
-        - exhaustive
-    - path: logzioexporter
-      linters:
-        - exhaustive
-    - path: prometheusexporter
-      linters:
-        - exhaustive
-    - path: prometheusremotewriteexporter
-      linters:
-        - exhaustive
-    - path: skywalkingexporter
-      linters:
-        - exhaustive
-    - path: splunkhecexporter
-      linters:
-        - exhaustive
-    - path: tanzuobservabilityexporter
-      linters:
-        - exhaustive
-    - path: k8sobserver
-      linters:
-        - exhaustive
-    - path: containerinsight
-      linters:
-        - exhaustive
-    - path: filter
-      linters:
-        - exhaustive
-    - path: coreinternal
-      linters:
-        - exhaustive
-    - path: k8sconfig
-      linters:
-        - exhaustive
-    - path: ottl
-      linters:
-        - exhaustive
-    - path: resourcetotelemetry
-      linters:
-        - exhaustive
-    - path: jaeger
-      linters:
-        - exhaustive
-    - path: prometheus
-      linters:
-        - exhaustive
-    - path: loki
-      linters:
-        - exhaustive
-    - path: opencensus
-      linters:
-        - exhaustive
-    - path: zipkin
-      linters:
-        - exhaustive
-    - path: configschema
-      linters:
-        - exhaustive
-    - path: testbed
-      linters:
-        - exhaustive
-    # Preserve original source code in attributed package.
-    - path: ctimefmt
-      linters:
-        - revive
+        - gosec
diff --git a/internal/coreinternal/timeutils/internal/ctimefmt/ctimefmt.go b/internal/coreinternal/timeutils/internal/ctimefmt/ctimefmt.go
@@ -19,7 +19,7 @@ import (
 var ctimeRegexp = regexp.MustCompile(`%.`)
 var decimalsRegexp = regexp.MustCompile(`\d`)
 
-var ctimeSubstitutes map[string]string = map[string]string{
+var ctimeSubstitutes = map[string]string{
 	"%Y": "2006",
 	"%y": "06",
 	"%m": "01",
@@ -129,9 +129,8 @@ func ToNative(format string) (string, error) {
 	replaceFunc := func(directive string) string {
 		if subst, ok := ctimeSubstitutes[directive]; ok {
 			return subst
-		} else {
-			errs = append(errs, errors.New("unsupported ctimefmt.ToNative() directive: "+directive))
 		}
+		errs = append(errs, errors.New("unsupported ctimefmt.ToNative() directive: "+directive))
 		return ""
 	}
 
diff --git a/internal/coreinternal/timeutils/internal/ctimefmt/ctimefmt_test.go b/internal/coreinternal/timeutils/internal/ctimefmt/ctimefmt_test.go
@@ -14,12 +14,12 @@ import (
 	"time"
 )
 
-var format1 string = "%Y-%m-%d %H:%M:%S.%f"
-var format2 string = "%Y-%m-%d %l:%M:%S.%L %P, %a"
-var value1 string = "2019-01-02 15:04:05.666666"
-var value2 string = "2019-01-02 3:04:05.666 pm, Wed"
-var dt1 time.Time = time.Date(2019, 1, 2, 15, 4, 5, 666666000, time.UTC)
-var dt2 time.Time = time.Date(2019, 1, 2, 15, 4, 5, 666000000, time.UTC)
+var format1 = "%Y-%m-%d %H:%M:%S.%f"
+var format2 = "%Y-%m-%d %l:%M:%S.%L %P, %a"
+var value1 = "2019-01-02 15:04:05.666666"
+var value2 = "2019-01-02 3:04:05.666 pm, Wed"
+var dt1 = time.Date(2019, 1, 2, 15, 4, 5, 666666000, time.UTC)
+var dt2 = time.Date(2019, 1, 2, 15, 4, 5, 666000000, time.UTC)
 
 func TestFormat(t *testing.T) {
 	s, err := Format(format1, dt1)
@@ -40,17 +40,17 @@ func TestFormat(t *testing.T) {
 }
 
 func TestParse(t *testing.T) {
-	dt_, err := Parse(format1, value1)
+	dt, err := Parse(format1, value1)
 	if err != nil {
 		t.Error(err)
-	} else if dt_ != dt1 {
-		t.Errorf("Given: %v, expected: %v", dt_, dt1)
+	} else if dt != dt1 {
+		t.Errorf("Given: %v, expected: %v", dt, dt1)
 	}
 
-	dt_, err = Parse(format2, value2)
+	dt, err = Parse(format2, value2)
 	if err != nil {
 		t.Error(err)
-	} else if dt_ != dt2 {
-		t.Errorf("Given: %v, expected: %v", dt_, dt2)
+	} else if dt != dt2 {
+		t.Errorf("Given: %v, expected: %v", dt, dt2)
 	}
 }
