Skip to content

Commit b3b1fde

Browse files
[chore] revert change of using VERSION vs version (#42076)
Follow-up to https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/42055/files#r2281820897 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent e9aa752 commit b3b1fde

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.github/actionlint.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,3 @@ config-variables: null
88
paths:
99
.github/workflows/**/*.{yml,yaml}:
1010
ignore:
11-
12-
# shellcheck gets confused between VERSION env var and version bash variable.
13-
- ".*VERSION may not be assigned. Did you mean version.*"

.github/workflows/auto-update-jmx-component.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ jobs:
7171
exit 1
7272
fi
7373
74-
version="${VERSION//-alpha/}"
75-
hash=$(curl -L "https://github.com/open-telemetry/opentelemetry-java-contrib/releases/download/v$version/opentelemetry-jmx-metrics.jar" \
74+
hash=$(curl -L "https://github.com/open-telemetry/opentelemetry-java-contrib/releases/download/v${VERSION//-alpha/}/opentelemetry-jmx-metrics.jar" \
7675
| sha256sum \
7776
| cut -d ' ' -f 1)
7877
@@ -180,14 +179,14 @@ jobs:
180179

181180
- name: Update version
182181
env:
183-
version: ${{ needs.check-jmx-scraper-version.outputs.latest-version }}
182+
VERSION: ${{ needs.check-jmx-scraper-version.outputs.latest-version }}
184183
run: |
185-
if [[ ! "$version" =~ -alpha$ ]]; then
184+
if [[ ! "$VERSION" =~ -alpha$ ]]; then
186185
echo currently expecting jmx scraper version to end with "-alpha"
187186
exit 1
188187
fi
189188
190-
hash=$(curl -L "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/$version/opentelemetry-jmx-scraper-$version.jar" \
189+
hash=$(curl -L "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/${VERSION//-alpha/}/opentelemetry-jmx-scraper-$VERSION.jar" \
191190
| sha256sum \
192191
| cut -d ' ' -f 1)
193192

0 commit comments

Comments
 (0)