[exporter/signalfx] root_path validation (#42696)

atoulme · github-actions[bot] · crobert-1 · web-flow · commit b74b0416b27a · 2025-09-15T16:43:02.000-07:00
#### Description Do not validate the root_path of the collector if `sync_host_metadata` is not set  #### Link to tracking issue Fixes #42688 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com>
diff --git a/.chloggen/validate_root_path.yaml b/.chloggen/validate_root_path.yaml
@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: signalfxexporter
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Only validate the root_path of the collector if `sync_host_metadata` is enabled.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [42688]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []
diff --git a/exporter/signalfxexporter/config.go b/exporter/signalfxexporter/config.go
@@ -228,10 +228,11 @@ func (cfg *Config) Validate() error {
 		return errors.New(`cannot have a negative "timeout"`)
 	}
 
-	if err := gopsutilenv.ValidateRootPath(cfg.RootPath); err != nil {
-		return fmt.Errorf("invalid root_path: %w", err)
+	if cfg.SyncHostMetadata {
+		if err := gopsutilenv.ValidateRootPath(cfg.RootPath); err != nil {
+			return fmt.Errorf("invalid root_path: %w", err)
+		}
 	}
-
 	return nil
 }
 
diff --git a/exporter/signalfxexporter/config_test.go b/exporter/signalfxexporter/config_test.go
@@ -461,6 +461,15 @@ func TestConfigValidateErrors(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "Invalid root_path",
+			cfg: &Config{
+				Realm:            "us0",
+				AccessToken:      "access_token",
+				RootPath:         "/foobar",
+				SyncHostMetadata: true,
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -228,10 +228,11 @@ func (cfg *Config) Validate() error {`
`228`	`228`	return errors.New(`cannot have a negative "timeout"`)
`229`	`229`	`}`
`230`	`230`
`231`		`- if err := gopsutilenv.ValidateRootPath(cfg.RootPath); err != nil {`
`232`		`- return fmt.Errorf("invalid root_path: %w", err)`
	`231`	`+ if cfg.SyncHostMetadata {`
	`232`	`+ if err := gopsutilenv.ValidateRootPath(cfg.RootPath); err != nil {`
	`233`	`+ return fmt.Errorf("invalid root_path: %w", err)`
	`234`	`+ }`
`233`	`235`	`}`
`234`		`-`
`235`	`236`	`return nil`
`236`	`237`	`}`
`237`	`238`