Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: onsi/ginkgo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.27.2
Choose a base ref
...
head repository: onsi/ginkgo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Dec 8, 2025

  1. ginkgo: fix data race 

        Write at 0x00c000368528 by goroutine 25:
      os/exec.(*Cmd).Wait()
          os/exec/exec.go:926 +0x1a4
      github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func2()
          github.com/onsi/ginkgo/[email protected]/ginkgo/internal/run.go:231 +0x37

    Previous read at 0x00c000368528 by goroutine 96714:
      github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func1()
          github.com/onsi/ginkgo/[email protected]/ginkgo/internal/run.go:228 +0x3b
      github.com/onsi/ginkgo/v2/internal/parallel_support.(*ServerHandler).procIsAlive()
          github.com/onsi/ginkgo/[email protected]/internal/parallel_support/server_handler.go:133 +0x121

The problem is that cmd.ProcessState is not thread-safe. The solution is an
atomic bool which gets checked instead and which is written once when the
goroutine waiting for the command has determined that the command has exited.
    @pohly @onsi
    pohly authored and onsi committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    ece19c8 View commit details
    Browse the repository at this point in the history

  2. ginkgo: report exit result in case of failure 

    When a worker unexpectedly dies, it's hard to determine why. Even if output is
available (--output-interceptor-mode=none), if it gets killed by the Linux OOM
killer there's nothing in the process output about that.

Including a textual description of the exit status provides that
information (here simulated with `killall -KILL e2e.test`):

    Output from proc 1:
        I1204 10:03:40.282670  196272 e2e.go:109] Starting e2e run "82689063-1787-40c3-be7d-c4677c556063" on Ginkgo node 1

    Exit result of proc 1:
      signal: killed
    @pohly @onsi
    pohly authored and onsi committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    1c9f356 View commit details
    Browse the repository at this point in the history

  3. v2.27.3

    @onsi
    onsi committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    f331739 View commit details
    Browse the repository at this point in the history
Loading