-
-
Notifications
You must be signed in to change notification settings - Fork 688
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: onsi/ginkgo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.27.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: onsi/ginkgo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 18 files changed
- 4 contributors
Commits on Oct 23, 2025
-
It seems the paragraph about NodeArgsTransformer was inserted in the wrong place. After “Here are a few more patterns that AroundNode enables.”, the following two subparagraphs should describe AroundNode-related content, same as before. The advanced features of NodeArgsTransformer should not interrupt that section. I’ve moved it accordingly, though please double-check that this new position makes sense.
Configuration menu - View commit details
-
Copy full SHA for f993df5 - Browse repository at this point
Copy the full SHA f993df5View commit details
Commits on Oct 24, 2025
-
Configuration menu - View commit details
-
Copy full SHA for a99c6e0 - Browse repository at this point
Copy the full SHA a99c6e0View commit details
Commits on Oct 27, 2025
-
inline automaxprocs to simplify dependencies; this will be removed wh…
…en Go 1.26 comes out
Configuration menu - View commit details
-
Copy full SHA for a69113a - Browse repository at this point
Copy the full SHA a69113aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a84c21 - Browse repository at this point
Copy the full SHA 9a84c21View commit details
Commits on Dec 8, 2025
-
Write at 0x00c000368528 by goroutine 25: os/exec.(*Cmd).Wait() os/exec/exec.go:926 +0x1a4 github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func2() github.com/onsi/ginkgo/[email protected]/ginkgo/internal/run.go:231 +0x37 Previous read at 0x00c000368528 by goroutine 96714: github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func1() github.com/onsi/ginkgo/[email protected]/ginkgo/internal/run.go:228 +0x3b github.com/onsi/ginkgo/v2/internal/parallel_support.(*ServerHandler).procIsAlive() github.com/onsi/ginkgo/[email protected]/internal/parallel_support/server_handler.go:133 +0x121 The problem is that cmd.ProcessState is not thread-safe. The solution is an atomic bool which gets checked instead and which is written once when the goroutine waiting for the command has determined that the command has exited.Configuration menu - View commit details
-
Copy full SHA for ece19c8 - Browse repository at this point
Copy the full SHA ece19c8View commit details -
ginkgo: report exit result in case of failure
When a worker unexpectedly dies, it's hard to determine why. Even if output is available (--output-interceptor-mode=none), if it gets killed by the Linux OOM killer there's nothing in the process output about that. Including a textual description of the exit status provides that information (here simulated with `killall -KILL e2e.test`): Output from proc 1: I1204 10:03:40.282670 196272 e2e.go:109] Starting e2e run "82689063-1787-40c3-be7d-c4677c556063" on Ginkgo node 1 Exit result of proc 1: signal: killedConfiguration menu - View commit details
-
Copy full SHA for 1c9f356 - Browse repository at this point
Copy the full SHA 1c9f356View commit details -
Configuration menu - View commit details
-
Copy full SHA for f331739 - Browse repository at this point
Copy the full SHA f331739View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.27.1...master