Added Duration on GinkgoTestDescription

eloycoto · eloycoto · commit 5f49dad1c4a2 · 2017-10-13T13:18:13.000+02:00
Signed-off-by: Eloy Coto &lt;eloy.coto@gmail.com&gt;
diff --git a/ginkgo_dsl.go b/ginkgo_dsl.go
@@ -149,7 +149,8 @@ type GinkgoTestDescription struct {
 	FileName   string
 	LineNumber int
 
-	Failed bool
+	Failed   bool
+	Duration time.Duration
 }
 
 //CurrentGinkgoTestDescripton returns information about the current running test.
@@ -169,6 +170,7 @@ func CurrentGinkgoTestDescription() GinkgoTestDescription {
 		FileName:       subjectCodeLocation.FileName,
 		LineNumber:     subjectCodeLocation.LineNumber,
 		Failed:         summary.HasFailureState(),
+		Duration:       summary.RunTime,
 	}
 }
 
diff --git a/internal/spec/spec.go b/internal/spec/spec.go
@@ -19,6 +19,7 @@ type Spec struct {
 
 	state            types.SpecState
 	runTime          time.Duration
+	startTime        time.Time
 	failure          types.SpecFailure
 	previousFailures bool
 }
@@ -97,7 +98,7 @@ func (spec *Spec) Summary(suiteID string) *types.SpecSummary {
 		ComponentTexts:         componentTexts,
 		ComponentCodeLocations: componentCodeLocations,
 		State:        spec.state,
-		RunTime:      spec.runTime,
+		RunTime:      time.Since(spec.startTime),
 		Failure:      spec.failure,
 		Measurements: spec.measurementsReport(),
 		SuiteID:      suiteID,
@@ -118,9 +119,9 @@ func (spec *Spec) Run(writer io.Writer) {
 		spec.previousFailures = true
 	}
 
-	startTime := time.Now()
+	spec.startTime = time.Now()
 	defer func() {
-		spec.runTime = time.Since(startTime)
+		spec.runTime = time.Since(spec.startTime)
 	}()
 
 	for sample := 0; sample < spec.subject.Samples(); sample++ {
diff --git a/internal/suite/suite_test.go b/internal/suite/suite_test.go
@@ -121,6 +121,7 @@ var _ = Describe("Suite", func() {
 			Ω(description.LineNumber).Should(BeNumerically(">", 50))
 			Ω(description.LineNumber).Should(BeNumerically("<", 150))
 			Ω(description.Failed).Should(BeFalse())
+			Ω(description.Duration).Should(BeNumerically(">", 0))
 		})
 
 		Measure("should run measurements", func(b Benchmarker) {

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,8 @@ type GinkgoTestDescription struct {`
`149`	`149`	`FileName string`
`150`	`150`	`LineNumber int`
`151`	`151`
`152`		`- Failed bool`
	`152`	`+ Failed bool`
	`153`	`+ Duration time.Duration`
`153`	`154`	`}`
`154`	`155`
`155`	`156`	`//CurrentGinkgoTestDescripton returns information about the current running test.`
`@@ -169,6 +170,7 @@ func CurrentGinkgoTestDescription() GinkgoTestDescription {`
`169`	`170`	`FileName: subjectCodeLocation.FileName,`
`170`	`171`	`LineNumber: subjectCodeLocation.LineNumber,`
`171`	`172`	`Failed: summary.HasFailureState(),`
	`173`	`+ Duration: summary.RunTime,`
`172`	`174`	`}`
`173`	`175`	`}`
`174`	`176`