chore: lint fixes for new lint (oras-project#1478)

Terry Howe · web-flow · commit 7b966ebfeb43 · 2024-08-14T13:10:13.000-06:00
Signed-off-by: Terry Howe &lt;terrylhowe@gmail.com&gt;
diff --git a/cmd/oras/internal/display/status/text_test.go b/cmd/oras/internal/display/status/text_test.go
@@ -40,7 +40,7 @@ func TestMain(m *testing.M) {
 	builder = &strings.Builder{}
 	printer = output.NewPrinter(builder, os.Stderr, false)
 	bogus = ocispec.Descriptor{MediaType: ocispec.MediaTypeImageManifest}
-	m.Run()
+	os.Exit(m.Run())
 }
 
 func validatePrinted(t *testing.T, expected string) {
diff --git a/cmd/oras/internal/option/remote_test.go b/cmd/oras/internal/option/remote_test.go
@@ -117,7 +117,7 @@ func TestMain(m *testing.M) {
 	ts.TLS = loadTestingTLSConfig()
 	ts.StartTLS()
 	defer ts.Close()
-	m.Run()
+	os.Exit(m.Run())
 }
 
 func TestRemote_FlagsInit(t *testing.T) {
diff --git a/cmd/oras/internal/output/print_test.go b/cmd/oras/internal/output/print_test.go
@@ -34,7 +34,7 @@ func (mw *mockWriter) Write(p []byte) (n int, err error) {
 		return len(string(p)), nil
 	}
 	mw.errorCount++
-	return 0, fmt.Errorf("Boom: " + string(p))
+	return 0, fmt.Errorf("boom %s", string(p))
 }
 
 func (mw *mockWriter) String() string {

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func TestMain(m *testing.M) {`
`40`	`40`	`builder = &strings.Builder{}`
`41`	`41`	`printer = output.NewPrinter(builder, os.Stderr, false)`
`42`	`42`	`bogus = ocispec.Descriptor{MediaType: ocispec.MediaTypeImageManifest}`
`43`		`- m.Run()`
	`43`	`+ os.Exit(m.Run())`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`func validatePrinted(t *testing.T, expected string) {`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ func TestMain(m *testing.M) {`
`117`	`117`	`ts.TLS = loadTestingTLSConfig()`
`118`	`118`	`ts.StartTLS()`
`119`	`119`	`defer ts.Close()`
`120`		`- m.Run()`
	`120`	`+ os.Exit(m.Run())`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`func TestRemote_FlagsInit(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func (mw *mockWriter) Write(p []byte) (n int, err error) {`
`34`	`34`	`return len(string(p)), nil`
`35`	`35`	`}`
`36`	`36`	`mw.errorCount++`
`37`		`- return 0, fmt.Errorf("Boom: " + string(p))`
	`37`	`+ return 0, fmt.Errorf("boom %s", string(p))`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`func (mw *mockWriter) String() string {`