feat: improve sourcemap support

pi0 · pi0 · commit 2753e1cfd83e · 2025-11-10T11:20:25.000+01:00
diff --git a/src/build/plugins.ts b/src/build/plugins.ts
@@ -18,6 +18,7 @@ import { rollupNodeFileTrace } from "nf3";
 import { rendererTemplate } from "./plugins/renderer-template.ts";
 import { featureFlags } from "./plugins/feature-flags.ts";
 import { nitroResolveIds } from "./plugins/resolve.ts";
+import { sourcemapMinify } from "./plugins/sourcemap-min.ts";
 
 export function baseBuildPlugins(nitro: Nitro, base: BaseBuildConfig) {
   const plugins: Plugin[] = [];
@@ -131,5 +132,14 @@ export function baseBuildPlugins(nitro: Nitro, base: BaseBuildConfig) {
     );
   }
 
+  // Minify
+  if (
+    nitro.options.sourcemap &&
+    !nitro.options.dev &&
+    nitro.options.experimental.sourcemapMinify !== false
+  ) {
+    plugins.push(sourcemapMinify());
+  }
+
   return plugins;
 }
diff --git a/src/build/plugins/sourcemap-min.ts b/src/build/plugins/sourcemap-min.ts
@@ -13,16 +13,20 @@ export function sourcemapMinify() {
         ) {
           continue;
         }
+
         // Parse sourcemap
         const sourcemap: ExistingRawSourceMap = JSON.parse(asset.source);
-        // Only process sourcemaps with node_module sources
-        if (
-          !(sourcemap.sources || []).some((s) => s.includes("node_modules"))
-        ) {
-          continue;
+
+        // Remove sourcesContent
+        delete sourcemap.sourcesContent;
+
+        // Remove x_google_ignoreList
+        delete sourcemap.x_google_ignoreList;
+
+        if ((sourcemap.sources || []).some((s) => s.includes("node_modules"))) {
+          sourcemap.mappings = ""; // required key
         }
-        // TODO: Try to treeshake mappings instead
-        sourcemap.mappings = "";
+
         asset.source = JSON.stringify(sourcemap);
       }
     },
diff --git a/src/build/rollup/config.ts b/src/build/rollup/config.ts
@@ -10,7 +10,6 @@ import json from "@rollup/plugin-json";
 import { nodeResolve } from "@rollup/plugin-node-resolve";
 import { replace } from "../plugins/replace.ts";
 import { oxc } from "../plugins/oxc.ts";
-import { sourcemapMinify } from "../plugins/sourcemap-min.ts";
 import { baseBuildConfig } from "../config.ts";
 import { baseBuildPlugins } from "../plugins.ts";
 import { raw } from "../plugins/raw.ts";
@@ -156,14 +155,5 @@ export const getRollupConfig = (nitro: Nitro): RollupConfig => {
     delete config.output.manualChunks;
   }
 
-  // Minify
-  if (
-    nitro.options.sourcemap &&
-    !nitro.options.dev &&
-    nitro.options.experimental.sourcemapMinify !== false
-  ) {
-    config.plugins.push(sourcemapMinify());
-  }
-
   return config;
 };
diff --git a/src/build/vite/env.ts b/src/build/vite/env.ts
@@ -31,6 +31,7 @@ export function createNitroEnvironment(
       rollupOptions: ctx.rollupConfig!.config as any,
       minify: ctx.nitro!.options.minify,
       emptyOutDir: false,
+      sourcemap: ctx.nitro!.options.sourcemap,
       commonjsOptions: {
         ...(ctx.nitro!.options.commonJS as any),
       },
@@ -64,6 +65,7 @@ export function createServiceEnvironment(
     build: {
       rollupOptions: { input: serviceConfig.entry },
       minify: ctx.nitro!.options.minify,
+      sourcemap: ctx.nitro!.options.sourcemap,
       outDir: join(ctx.nitro!.options.buildDir, "vite/services", name),
       emptyOutDir: true,
     },
diff --git a/src/build/vite/rollup.ts b/src/build/vite/rollup.ts
@@ -16,7 +16,7 @@ import type { NitroPluginContext } from "./types.ts";
  *  - nodeResolve
  *  - commonjs
  *  - esbuild
- *  - sourcemapMininify
+ *  - sourcemapMinify
  *  - json
  *  - raw
  *
diff --git a/test/minimal/minimal.test.ts b/test/minimal/minimal.test.ts
@@ -11,10 +11,10 @@ const tmpDir = fileURLToPath(new URL(".tmp", import.meta.url));
 
 // Rounded up
 const bundleSizes: Record<string, [kb: number, minKB: number]> = {
-  rollup: [15, isWindows ? 10 : 9],
-  rolldown: [20, 8],
-  vite: [18, 10],
-  "rolldown-vite": [17, 10],
+  rollup: [16, isWindows ? 12 : 11],
+  rolldown: [20, 9],
+  vite: [19, 12],
+  "rolldown-vite": [18, 11],
 };
 
 describe("minimal fixture", () => {
diff --git a/test/minimal/nitro.config.ts b/test/minimal/nitro.config.ts
@@ -2,5 +2,5 @@ import { defineNitroConfig } from "nitro/config";
 
 export default defineNitroConfig({
   preset: "standard",
-  sourcemap: false,
+  // sourcemap: false,
 });

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ import type { NitroPluginContext } from "./types.ts";`
`16`	`16`	`* - nodeResolve`
`17`	`17`	`* - commonjs`
`18`	`18`	`* - esbuild`
`19`		`- * - sourcemapMininify`
	`19`	`+ * - sourcemapMinify`
`20`	`20`	`* - json`
`21`	`21`	`* - raw`
`22`	`22`	`*`