Activate magithub-minor-mode more conservatively

DarwinAwardWinner · DarwinAwardWinner · commit a5f66d76fc9b · 2012-01-14T18:23:55.000-08:00
Replace "magithub-try-enabling-minor-mode-everywhere" with
"magithub-try-enabling-minor-mode-for-repo", which only tries to
enable magithub-minor-mode for buffers corresponding to files in the
current repo.

This solves the issue with magithub hanging indefinitely when you have
a remote file open on a currently-inaccessible server. In such cases,
magithub would try to enable its minro mode in the remote file's
buffer, which would cause TRAMP to try to reconnect to the server,
which would hang because the server was inaccessible.
diff --git a/magithub.el b/magithub.el
@@ -1130,10 +1130,18 @@ See `magithub-try-enabling-minor-mode'."
   (when (and magithub-minor-mode (buffer-live-p magithub-status-buffer))
     (magithub-minor-mode -1)))
 
-(defun magithub-try-enabling-minor-mode-everywhere ()
-  "Run `magithub-try-enabling-minor-mode' on all buffers."
-  (dolist (buf (buffer-list))
-    (with-current-buffer buf (magithub-try-enabling-minor-mode))))
+(defun magithub-try-enabling-minor-mode-for-repo ()
+  "Run `magithub-try-enabling-minor-mode' on all buffers in the current repo."
+  (let* ((repo-directory (magit-get-top-dir default-directory))
+         (regexp (concat "^" (regexp-quote repo-directory))))
+    (message "Working in %s" repo-directory)
+    (message "Searching with %s" regexp)
+    (when repo-directory
+      (dolist (buf (buffer-list))
+        (with-current-buffer buf
+          (when (and (buffer-file-name)
+                     (string-match-p regexp default-directory))
+            (magithub-try-enabling-minor-mode)))))))
 
 (defun magithub-try-disabling-minor-mode-everywhere ()
   "Run `magithub-try-disabling-minor-mode' on all buffers."
@@ -1155,7 +1163,7 @@ See `magithub-try-enabling-minor-mode'."
 If the new `magit-mode' buffer is a status buffer, try enabling
 `magithub-minor-mode' in all buffers."
   (when (derived-mode-p 'magit-status-mode)
-    (magithub-try-enabling-minor-mode-everywhere)))
+    (magithub-try-enabling-minor-mode-for-repo)))
 (add-hook 'magit-mode-hook 'magithub-magit-mode-hook)
 
 (defun magithub-kill-buffer-hook ()
