Skip to content

Commit 22fa3ab

Browse files
Merge pull request #152 from monta-app/fix/changelog-and-tag-skipped
fix: Try fixing tag and changelog creation being skipped in deploy-kotlin
2 parents 9953351 + 84c1831 commit 22fa3ab

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

.github/workflows/create-release-tag.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
uses: actions/checkout@v4
2020
with:
2121
fetch-depth: 0
22-
token: ${{ secrets.GITHUB_TOKEN }}
22+
token: ${{ secrets.MONTA_BOT_TOKEN }}
2323
- name: Generate tag name
2424
id: generate_tag
2525
run: |
@@ -39,8 +39,8 @@ jobs:
3939
tag="${{ steps.generate_tag.outputs.tag }}"
4040
4141
# Configure git
42-
git config user.name "github-actions[bot]"
43-
git config user.email "github-actions[bot]@users.noreply.github.com"
42+
git config user.name "Monta Bot"
43+
git config user.email "bot@monta.com"
4444
4545
# Create the tag
4646
git tag "$tag"

.github/workflows/deploy-kotlin.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,6 @@ permissions:
122122
actions: write
123123

124124
jobs:
125-
create-release-tag:
126-
name: Create Release Tag
127-
if: inputs.enable-release-tag && github.event_name == 'workflow_dispatch'
128-
uses: ./.github/workflows/create-release-tag.yml
129-
with:
130-
prefix: ${{ inputs.release-tag-prefix }}
131125
initialize:
132126
name: Initialize
133127
needs: [ create-release-tag ]
@@ -199,10 +193,17 @@ jobs:
199193
secrets:
200194
MANIFEST_REPO_PAT: ${{ secrets.MANIFEST_REPO_PAT }}
201195
SLACK_APP_TOKEN: ${{ secrets.SLACK_APP_TOKEN }}
196+
create-release-tag:
197+
name: Create Release Tag
198+
if: always() && inputs.enable-release-tag && needs.deploy.result == 'success'
199+
needs: deploy
200+
uses: ./.github/workflows/create-release-tag.yml
201+
with:
202+
prefix: ${{ inputs.release-tag-prefix }}
202203
create-changelog:
203204
name: Create and Publish Changelog
204205
needs: deploy
205-
if: inputs.enable-changelog && needs.deploy.result == 'success'
206+
if: always() && inputs.enable-changelog && needs.deploy.result == 'success'
206207
runs-on: ubuntu-latest
207208
timeout-minutes: 5
208209
steps:

0 commit comments

Comments
 (0)