Failed unsetting default-address-pools in daemon.json #49353
Description
Description
When default-address-pools key in /etc/docker/daemon.json is set and docker daemon is reloaded which effects the changes, an user could no longer unset the overridden default-address-pools. Even if the key is deleted from /etc/docker/daemon.json, the ip/cidr presists.
Reproduce
- install docker, via package manager, start docker
ip agives something similar to: (other links thandocker0are omitted)
8: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
link/ether 02:42:9d:36:7d:78 brd ff:ff:ff:ff:ff:ff
inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0
valid_lft forever preferred_lft forever
- modify
/etc/docker/daemon.jsonand restart docker daemon
{"default-address-pools": [{"base": "198.18.0.0/15", "size": 26}]}
ip agives something similar to: (note172.17.0.1/16changed to198.18.0.1/26, which is expected)
9: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
link/ether 02:42:9d:51:0c:69 brd ff:ff:ff:ff:ff:ff
inet 198.18.0.1/26 brd 198.18.0.63 scope global docker0
valid_lft forever preferred_lft forever
- empty
/etc/docker/daemon.json, restart docker daemon ip agives something similar to: (note198.18.0.1/26, which is unexpected, the default,172.17.0.1/16, is expected)
10: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
link/ether 02:42:d9:dc:7d:6b brd ff:ff:ff:ff:ff:ff
inet 198.18.0.1/26 brd 198.18.0.63 scope global docker0
valid_lft forever preferred_lft forever
Expected behavior
docker's address pool returns back to default when the key default-address-pools has been deleted from /etc/docker/daemon.json
docker version
Client:
Version: 27.3.1
API version: 1.47
Go version: go1.23.1
Git commit: ce1223035a
Built: Wed Sep 25 14:43:43 2024
OS/Arch: linux/amd64
Context: default
Server:
Engine:
Version: 27.3.1
API version: 1.47 (minimum version 1.24)
Go version: go1.23.1
Git commit: 41ca978a0a
Built: Wed Sep 25 14:43:43 2024
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: v2.0.2
GitCommit: c507a0257ea6462fbd6f5ba4f5c74facb04021f4.m
runc:
Version: 1.2.4
GitCommit:
docker-init:
Version: 0.19.0
GitCommit: de40ad0docker info
Client:
Version: 27.3.1
Context: default
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: 0.20.1
Path: /usr/lib/docker/cli-plugins/docker-buildx
compose: Docker Compose (Docker Inc.)
Version: 2.32.4
Path: /usr/lib/docker/cli-plugins/docker-compose
Server:
Containers: 0
Running: 0
Paused: 0
Stopped: 0
Images: 0
Server Version: 27.3.1
Storage Driver: overlay2
Backing Filesystem: btrfs
Supports d_type: true
Using metacopy: true
Native Overlay Diff: false
userxattr: false
Logging Driver: json-file
Cgroup Driver: systemd
Cgroup Version: 2
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 runc
Default Runtime: runc
Init Binary: docker-init
containerd version: c507a0257ea6462fbd6f5ba4f5c74facb04021f4.m
runc version:
init version: de40ad0
Security Options:
seccomp
Profile: builtin
cgroupns
Kernel Version: 6.12.10-zen1-1-zen
Operating System: Arch Linux
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.18GiB
Name: Leo-NUC
ID: 10723c22-66eb-46c4-8e55-3c77827f0dd3
Docker Root Dir: /var/lib/docker
Debug Mode: false
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: falseAdditional Info
N/A