chore: replace nps with npm scripts
#5128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes please |
Member
Author
|
Related: #5159 I would suggest moving the |
Thanks to the unfolding placeholder in npm-run-all2 6.2.0: bcomnes/npm-run-all2#134
voxpelli
added a commit
that referenced
this pull request
Jul 15, 2024
voxpelli
added a commit
that referenced
this pull request
Jul 15, 2024
Member
Author
|
Waiting for #5177 before I continue on this one, as they overlap |
voxpelli
added a commit
that referenced
this pull request
Aug 1, 2024
* ci: use `npm ci` consistently * ci: use `actions/setup-node` cache mechanism * ci: reusable workflow for DRY:er setup * ci: remove unused `delete-runs.yml` * ci: fix matrix definitions * ci: fix matrix definitions, take 2 * ci: ensure they all scripts can use `npm run` See also #5128 * ci: add node 22 to `test-node` * ci: have the coverage run always happen on `lts/*` * ci: set permissions * ci: lock down all non-github actions by hash * ci: use reusable workflow for full tests as well * ci: remove redundant activity types * ci: add one more permissions * ci: use full sha hashes for third party workflows * ci: be consistent in naming * ci: generate the coverage report using nps for now See #5126 * ci: parallelize, run local browser test right away * ci: disable saucelabs for now, too noisy
0c6aac3 to
543d517
Compare
3 tasks
nps with npm scriptsnps with npm scripts
voxpelli
commented
Aug 2, 2024
This reverts commit 560b35f.
Member
Author
|
Created a related feature request for VSCode: microsoft/vscode#224581 Requesting syntax highlighting of npm scripts |
JoshuaKGoldberg
approved these changes
Aug 3, 2024
Member
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
this looks wonderful, thank you!
It's hard to review such a sweeping PR - but everything works on my end.
Member
|
Great success |
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
npswith ordinary npm scripts #5126status: accepting prsOverview
Work in progress draft branch to keep #5042 cleaner and more focused
Remaining
mocha/.github/DEVELOPMENT.md
Line 20 in 9692b3a